Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

histogram: option to enable/disable zero-fill #612

Closed
wants to merge 1 commit into from
Closed

histogram: option to enable/disable zero-fill #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/app/panels/histogram/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ function (angular, app, $, _, kbn, moment, timeSeries) {
* linewidth:: Weight of lines in pixels
*/
linewidth : 3,
gapfill : 'minimal',
/** @scratch /panels/histogram/3
* points:: Show points on chart
*/
Expand Down Expand Up @@ -409,7 +410,7 @@ function (angular, app, $, _, kbn, moment, timeSeries) {
interval: _interval,
start_date: _range && _range.from,
end_date: _range && _range.to,
fill_style: $scope.panel.derivative ? 'null' : 'minimal'
fill_style: $scope.panel.derivative ? 'null' : $scope.panel.gapfill
};
time_series = new timeSeries.ZeroFilled(tsOpts);
hits = 0;
Expand Down
4 changes: 4 additions & 0 deletions src/app/panels/histogram/styleEditor.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ <h5>Chart Options</h5>
<label class="small">xAxis</label><input type="checkbox" ng-model="panel['x-axis']" ng-checked="panel['x-axis']"></div>
<div class="editor-option">
<label class="small">yAxis</label><input type="checkbox" ng-model="panel['y-axis']" ng-checked="panel['y-axis']"></div>
<div class="editor-option" ng-hide="panel.derivative">
<label class="small">Gap Fill</label>
<select class="input-mini" ng-model="panel.gapfill" ng-options="f for f in ['all','null','no']">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is missing a closing select tag. Used like this it overwrites the Line Fill Option.

Otherwise a very useful change, that I'd love to see merged.

</div>
<div class="editor-option" ng-show="panel.lines">
<label class="small">Line Fill</label>
<select class="input-mini" ng-model="panel.fill" ng-options="f for f in [0,1,2,3,4,5,6,7,8,9,10]"></select>
Expand Down