Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move crypto to server utils #62344

Merged
merged 2 commits into from
Apr 2, 2020

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Apr 2, 2020

Summary

Part of #62263
It's used in nodejs env only and shouldn't be imported in a browser. Now it bloats all the client-side plugins that imports anything from src/core/utils (+300 kB minified code per bundle).

@mshustov mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Apr 2, 2020
@mshustov mshustov requested a review from a team as a code owner April 2, 2020 16:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@mshustov mshustov merged commit 4cb96ee into elastic:master Apr 2, 2020
@mshustov mshustov deleted the issue-62238-cleanup-imports branch April 2, 2020 19:42
mshustov added a commit to mshustov/kibana that referenced this pull request Apr 2, 2020
* move crypto to server utils

* fix mocks
mshustov added a commit to mshustov/kibana that referenced this pull request Apr 2, 2020
* move crypto to server utils

* fix mocks
mshustov added a commit that referenced this pull request Apr 3, 2020
* move crypto to server utils

* fix mocks
mshustov added a commit that referenced this pull request Apr 3, 2020
* move crypto to server utils

* fix mocks
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 3, 2020
* master:
  [Drilldowns] Dashboard state fixes for drilldowns (elastic#61457)
  allow null for filterQuery (elastic#62310)
  [ML] call job validation endpoint with complete payload (elastic#62331)
  removing configuration from agents (elastic#62290)
  Allow Enterprise license for service map (elastic#62371)
  docs: updates to apm agent config (elastic#61893)
  [Ingest] Fix package info request returning 500 (elastic#61712)
  move crypto to server utils (elastic#62344)
  Start indexing documents by default (elastic#62159)
  [Endpoint] Update host field accordion (elastic#61878)
  Add more definitions about Ingest Management (elastic#62049)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants