Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate sample-data-telemetry saved object registration to Kibana platform #63965

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Migrate sample-data-telemetry saved object registration to Kibana platform #63965

merged 2 commits into from
Apr 22, 2020

Conversation

kertal
Copy link
Member

@kertal kertal commented Apr 20, 2020

Summary

Move the sample-data-telemetry saved object type registration from the legacy world to Kibana platform.

Part of #61259

@kertal kertal added Feature:Home Kibana home application Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration v7.8.0 labels Apr 20, 2020
@kertal kertal self-assigned this Apr 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal marked this pull request as ready for review April 20, 2020 18:45
@kertal kertal requested review from flash1293 and a team April 21, 2020 06:03
@flash1293 flash1293 mentioned this pull request Apr 21, 2020
Closed
6 tasks
flash1293
flash1293 approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and saved object is still written successfully, LGTM.

@kertal
Copy link
Member Author

kertal commented Apr 22, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kertal kertal merged commit 54ca7ed into elastic:master Apr 22, 2020
@kertal kertal mentioned this pull request Apr 22, 2020
Merged
kertal added a commit to kertal/kibana that referenced this pull request Apr 22, 2020
@kertal
Migrate sample-data-telemetry registration to Kibana platform (elasti…
65ab16f 
…c#63965)
kertal added a commit that referenced this pull request Apr 22, 2020
@kertal
Migrate sample-data-telemetry registration to Kibana platform (#63965) (
fa509f1 
#64206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees

@kertal kertal

Labels
Feature:Home Kibana home application Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kertal @elasticmachine @kibanamachine @flash1293