-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Fixes reordering in view by swimlane when overall cell selected #65290
Merged
peteharverson
merged 1 commit into
elastic:master
from
peteharverson:ml-explorer-swimlane-reorder
May 6, 2020
Merged
[ML] Fixes reordering in view by swimlane when overall cell selected #65290
peteharverson
merged 1 commit into
elastic:master
from
peteharverson:ml-explorer-swimlane-reorder
May 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
release_note:fix
:ml
Feature:Anomaly Detection
ML anomaly detection
v8.0.0
v7.8.0
labels
May 5, 2020
Pinging @elastic/ml-ui (:ml) |
peteharverson
changed the title
[ML] Fixes reordering in view by selection when overall cell selected
[ML] Fixes reordering in view by swimlane when overall cell selected
May 5, 2020
💚 Build SucceededTo update your PR or re-run it, just comment with: |
walterra
approved these changes
May 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
May 6, 2020
peteharverson
added a commit
that referenced
this pull request
May 6, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 6, 2020
* master: (72 commits) add tsvb tests to Firefox suite (elastic#65425) Fix flaky ServerMetricsCollector integration test (elastic#65420) [APM] Custom links section inside the Actions menu is showing outside of the menu (elastic#65428) [ML] Adds docs_per_second to transform edit form. (elastic#65365) update apm index pattern (elastic#65424) add direct build command (elastic#65431) [ML] Adding daily_model_snapshot_retention_after_days to types and schemas (elastic#65417) [chore] Improve request cancelation handling in vis embeddable (elastic#65057) [Alerting] migrates acceptance and functional test fixtures to KP (elastic#64888) [ML] Fixes reordering in view by selection when overall cell selected (elastic#65290) Additional branding updates (elastic#64712) Remove redundant formatting of percentage column (elastic#64948) [SIEM][CASE] Configuration pages UI redesign (elastic#65355) New nav (elastic#64018) [Ingest pipelines] Address copy feedback (elastic#65175) bug fixing (elastic#65387) skip whole suite blocking snapshots (elastic#65377) add related event generation to ancestor nodes (fixes a bug) (elastic#64950) [Canvas] move files from legacy/plugins to plugins (elastic#65283) [SIEM] template timeline UI (elastic#64439) ...
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
May 6, 2020
peteharverson
added a commit
that referenced
this pull request
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the re-ordering of the 'view by' swimlane in the Anomaly Explorer when a cell in the 'overall' swimlane selected. Selection in the 'overall' swimlane now reorders the 'view by' swimlane, to show the top n by max anomaly score for the time of the selected cell.
Fixes #63565