Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Custom links section inside the Actions menu is showing outside of the menu. #65428

Merged
merged 1 commit into from
May 6, 2020

Conversation

cauemarcondes
Copy link
Contributor

closes #64404

Screenshot 2020-05-06 at 10 31 24

Screenshot 2020-05-06 at 10 31 30

@cauemarcondes cauemarcondes requested a review from a team as a code owner May 6, 2020 08:49
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label May 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code removal is the bug fix I love the most 👍 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 4e2b944 into elastic:master May 6, 2020
@cauemarcondes cauemarcondes deleted the custom-links branch May 6, 2020 10:50
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 6, 2020
* master: (72 commits)
  add tsvb tests to Firefox suite (elastic#65425)
  Fix flaky ServerMetricsCollector integration test (elastic#65420)
  [APM] Custom links section inside the Actions menu is showing outside of the menu (elastic#65428)
  [ML] Adds docs_per_second to transform edit form. (elastic#65365)
  update apm index pattern (elastic#65424)
  add direct build command (elastic#65431)
  [ML] Adding daily_model_snapshot_retention_after_days to types and schemas (elastic#65417)
  [chore] Improve request cancelation handling in vis embeddable (elastic#65057)
  [Alerting] migrates acceptance and functional test fixtures to KP (elastic#64888)
  [ML] Fixes reordering in view by selection when overall cell selected (elastic#65290)
  Additional branding updates (elastic#64712)
  Remove redundant formatting of percentage column (elastic#64948)
  [SIEM][CASE] Configuration pages UI redesign (elastic#65355)
  New nav (elastic#64018)
  [Ingest pipelines] Address copy feedback (elastic#65175)
  bug fixing (elastic#65387)
  skip whole suite blocking snapshots (elastic#65377)
  add related event generation to ancestor nodes (fixes a bug) (elastic#64950)
  [Canvas] move files from legacy/plugins to plugins (elastic#65283)
  [SIEM] template timeline UI (elastic#64439)
  ...
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request May 6, 2020
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request May 6, 2020
@sorenlouv sorenlouv added the apm:test-plan-done Pull request that was successfully tested during the test plan label May 28, 2020
@sorenlouv
Copy link
Member

Works as expected

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:test-plan-7.8.0 apm:test-plan-done Pull request that was successfully tested during the test plan release_note:fix Team:APM All issues that need APM UI Team support v7.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Custom links section inside the Actions menu is showing outside of the menu.
4 participants