Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Data Frame Analytics: Fix steps to be named phases. #65855

Merged
merged 9 commits into from
May 13, 2020
Merged

[ML] Data Frame Analytics: Fix steps to be named phases. #65855

merged 9 commits into from
May 13, 2020

Conversation

walterra
Copy link
Contributor

@walterra walterra commented May 8, 2020 •
edited
Loading

Summary

Fixes #65607.

  • Fixes wrong names and renames everything related to step to phase.
  • Renames column heading Progress per Step to just Progress.
  • Hide the progress bar percentage, instead it's available in a tooltip.
  • Changes the progress column content to Phase 1/4 [ProgressBar].

image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@walterra walterra self-assigned this May 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes labels May 8, 2020
@walterra walterra marked this pull request as ready for review May 8, 2020 14:54
@walterra walterra requested a review from a team as a code owner May 8, 2020 14:54
@qn895
Copy link
Member

qn895 commented May 8, 2020

Tested and code LGTM

@walterra
Copy link
Contributor Author

@elasticmachine merge upstream

jgowdyelastic
jgowdyelastic approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@walterra
Copy link
Contributor Author

@elasticmachine merge upstream

peteharverson
peteharverson reviewed May 11, 2020
View reviewed changes
...cation/data_frame_analytics/pages/analytics_management/components/analytics_list/columns.tsx Outdated
</EuiText>
</EuiFlexItem>
<EuiFlexItem style={{ width: '40px' }} grow={false}>
<EuiToolTip content={`Progress of phase ${currentPhase}: ${progress}%`}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs internationalizing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in bad6c67.

peteharverson
peteharverson approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One missed translation, but otherwise tested and LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@walterra
Copy link
Contributor Author

@elasticmachine merge upstream

@walterra
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@walterra walterra merged commit 115ede9 into elastic:master May 13, 2020
@walterra walterra deleted the ml-analytics-progress-fix branch May 13, 2020 10:16
walterra added a commit to walterra/kibana that referenced this pull request May 13, 2020
@walterra
[ML] Data Frame Analytics: Fix steps to be named phases. (elastic#65855)
45f45c5 
- Fixes wrong names and renames everything related to step to phase.
- Renames column heading Progress per Step to just Progress.
- Hide the progress bar percentage, instead it's available in a tooltip.
- Changes the progress column content to Phase 1/4 [ProgressBar].
@walterra walterra mentioned this pull request May 13, 2020
Merged
walterra added a commit to walterra/kibana that referenced this pull request May 13, 2020
@walterra
[ML] Data Frame Analytics: Fix steps to be named phases. (elastic#65855)
b7a500e 
- Fixes wrong names and renames everything related to step to phase.
- Renames column heading Progress per Step to just Progress.
- Hide the progress bar percentage, instead it's available in a tooltip.
- Changes the progress column content to Phase 1/4 [ProgressBar].
@walterra walterra mentioned this pull request May 13, 2020
Merged
walterra added a commit that referenced this pull request May 13, 2020
@walterra
[ML] Data Frame Analytics: Fix steps to be named phases. (#65855) (#6…
191f935 
…6379)

- Fixes wrong names and renames everything related to step to phase.
- Renames column heading Progress per Step to just Progress.
- Hide the progress bar percentage, instead it's available in a tooltip.
- Changes the progress column content to Phase 1/4 [ProgressBar].
v1v added a commit to v1v/kibana that referenced this pull request May 13, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/e2e-changes
58bdbbd 
* upstream/master: (223 commits)
  [Ingest] Support root level yaml variables in agent stream template (elastic#66120)
  [Snapshot Restore] Fix error when deleting snapshots behind reverse proxy (elastic#66147)
  [Lens] fix empty state for pie (elastic#66206)
  [APM] Improve e2e tests (elastic#66373)
  [ML] Data Frame Analytics: Fix steps to be named phases. (elastic#65855)
  [Discover] Encode context link filter part (elastic#63831)
  [APM] Scope APM alert creation to environment (elastic#65681)
  Move Kibana Usage collectors outside the telemetry plugin (elastic#65663)
  [ML] Data Frame Analytics: Fix confusion matrix data grid width. (elastic#65818)
  Switch to core application service (elastic#63443)
  Removes use of prefer_v2_templates (elastic#66316)
  [Maps] handle case where fit to bounds does not match any documents (elastic#66307)
  log error instead of throw (elastic#66254)
  [plugin-helpers] remove outdated postinstall task (elastic#66324)
  Spaces - migrate default space and enter space view to KP (elastic#66098)
  [APM] Change plugin id for `apm_oss` to `apmOss` (elastic#66164)
  [Maps] convert map_selectors to TS (elastic#65905)
  [uptime/usage-collector] add missing await (elastic#66079)
  [Ingest] Add additional attributes to the Datasources Saved Object (elastic#66127)
  [Endpoint]EMT-339: add new policy response schema (elastic#66264)
  ...
walterra added a commit that referenced this pull request May 13, 2020
@walterra
[ML] Data Frame Analytics: Fix steps to be named phases. (#65855) (#6…
63c0952 
…6378)

- Fixes wrong names and renames everything related to step to phase.
- Renames column heading Progress per Step to just Progress.
- Hide the progress bar percentage, instead it's available in a tooltip.
- Changes the progress column content to Phase 1/4 [ProgressBar].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

Assignees

@walterra walterra

Labels
bug Fixes for quality problems that affect the customer experience Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Data Frame Analytics: Improve analysis progress in job list
7 participants
@walterra @elasticmachine @qn895 @kibanamachine @alvarezmelissa87 @peteharverson @jgowdyelastic