Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [APM] Change plugin id for apm_oss to apmOss (#66164) #66330

Merged
merged 5 commits into from
May 18, 2020
Merged

[7.x] [APM] Change plugin id for apm_oss to apmOss (#66164) #66330

merged 5 commits into from
May 18, 2020

Conversation

ogupte
Copy link
Contributor

@ogupte ogupte commented May 12, 2020

Backports the following commits to 7.x:

@ogupte @mohinderps
[APM] Change plugin id for apm_oss to apmOss (elastic#66164)
d5710fb 
* Change apm oss plugin name from apm_oss to apmOss

* change plugin name

* update apm_oss -> apmOss inn requiredPlugins

Co-authored-by: mohinderps <mohin19derp@gmail.com>
@ogupte
Copy link
Contributor Author

ogupte commented May 13, 2020

retest

@ogupte
Copy link
Contributor Author

ogupte commented May 13, 2020

@elasticmachine merge upstream

@ogupte
Copy link
Contributor Author

ogupte commented May 14, 2020

@elasticmachine merge upstream

@ogupte
Copy link
Contributor Author

ogupte commented May 18, 2020

@elasticmachine merge upstream

jloleysens
jloleysens approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test locally, happy for this to be merged if CI passes.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ogupte ogupte merged commit ff7dc09 into elastic:7.x May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ogupte @kibanamachine @jloleysens @elasticmachine