Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data redesign #6993

Merged
merged 5 commits into from
Apr 21, 2016
Merged

Add data redesign #6993

merged 5 commits into from
Apr 21, 2016

Conversation

BigFunger
Copy link
Contributor

depends on #6992

  • Changes the layout of the pipeline setup page to be side-by-side
  • Modifies some of the tooltips for consistancy
  • processor previews are expanded by default
  • Adds instruction text at the top of the pipeline setup page
  • Applies other color and spacing changes per design mockups

@BigFunger BigFunger added review Feature:Add Data Add Data and sample data feature on Home labels Apr 20, 2016
@BigFunger BigFunger mentioned this pull request Apr 20, 2016
Merged
@Bargs
Copy link
Contributor

Bargs commented Apr 20, 2016

@BigFunger have you and @alt74 discussed the vertical overflow behavior of the pipeline output box? I feel like it should expand to fit its contents instead of scrolling. It's weird how collapsing a processor can cause the pipeline output to be cut off.

cutoff

@BigFunger
Copy link
Contributor Author

As far as I understand, the right panel should match the height of the left panel, with a minimum height of 300px. @alt74 That's correct, right?

@alt74
Copy link

alt74 commented Apr 21, 2016 •
edited
Loading

I think it would be ok if we increase the minimum height to 500 px - that way there is more vertical room in the pipeline output box and the next button should still be above the fold. @BigFunger could you give this a shot? thx!

Bargs
Bargs reviewed Apr 21, 2016
View reviewed changes
src/plugins/kibana/public/settings/sections/indices/filebeat/directives/filebeat_wizard.html
Prev
</button>
</div>
<div class="col2">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This col2 class doesn't seem to do anything as far as I can tell.

@Bargs
Copy link
Contributor

Bargs commented Apr 21, 2016

Since you created a _filebeat_wizard.less file, could you move a couple filebeat styles from settings/styles/main.less into it?

https://github.com/elastic/kibana/blob/feature/ingest/src/plugins/kibana/public/settings/styles/main.less#L209
and
https://github.com/elastic/kibana/blob/feature/ingest/src/plugins/kibana/public/settings/styles/main.less#L262

@Bargs
Copy link
Contributor

Bargs commented Apr 21, 2016

@BigFunger just two small things mentioned, back to you

@Bargs Bargs assigned BigFunger and unassigned Bargs Apr 21, 2016
@BigFunger BigFunger assigned Bargs and unassigned BigFunger Apr 21, 2016
@Bargs
Copy link
Contributor

Bargs commented Apr 21, 2016

LGTM

@Bargs Bargs assigned BigFunger and unassigned Bargs Apr 21, 2016
@BigFunger BigFunger merged commit a00e033 into elastic:feature/ingest Apr 21, 2016
lgestc added a commit that referenced this pull request Jul 6, 2023
@lgestc
Store last conversation in in localstorage #6993
92e3a57
@lgestc lgestc mentioned this pull request Jul 6, 2023
Merged
1 task
lgestc added a commit that referenced this pull request Jul 7, 2023
@lgestc
[Security Solution] Store last conversation in localstorage #6993
67da505
lgestc added a commit that referenced this pull request Jul 10, 2023
@lgestc
[Security Solution] Store last conversation in localstorage #6993
35c6ecb
stephmilovic pushed a commit that referenced this pull request Jul 12, 2023
@lgestc
[Security Solution] Store last conversation in localstorage #6993 (#1…
ca3146f 
…61373)
spong pushed a commit to spong/kibana that referenced this pull request Jul 12, 2023
@lgestc
[Security Solution] Store last conversation in localstorage elastic#6993
5c54496 
 (elastic#161373)

(cherry picked from commit ca3146f)
spong added a commit that referenced this pull request Jul 12, 2023
@spong @lgestc
[8.9] [Security Solution] Store last conversation in localstorage #6993…
f3015c7 
… (#161373) (#161743)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Security Solution] Store last conversation in localstorage #6993
(#161373)](#161373)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Luke","email":"11671118+lgestc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-07-12T01:02:11Z","message":"[Security
Solution] Store last conversation in localstorage #6993
(#161373)","sha":"ca3146f0ca5dc1d003214878bbf60d0aa1f00a1d","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.9.0","Feature:Elastic
Assistant","v8.10.0"],"number":161373,"url":"https://github.com/elastic/kibana/pull/161373","mergeCommit":{"message":"[Security
Solution] Store last conversation in localstorage #6993
(#161373)","sha":"ca3146f0ca5dc1d003214878bbf60d0aa1f00a1d"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161373","number":161373,"mergeCommit":{"message":"[Security
Solution] Store last conversation in localstorage #6993
(#161373)","sha":"ca3146f0ca5dc1d003214878bbf60d0aa1f00a1d"}}]}]
BACKPORT-->

Co-authored-by: Luke <11671118+lgestc@users.noreply.github.com>
cee-chen added a commit that referenced this pull request Aug 21, 2023
@cee-chen @kibanamachine @patrykkopycinski
Upgrade EUI to v87.1.0 (#163961)
84ca85d 
`v86.0.0`⏩`v87.1.0`

⚠️ The biggest set of type changes in this PR come from the breaking
change that makes `pageSize` and `pageSizeOptions` now optional props
for `EuiBasicTable.pagination`, `EuiInMemoryTable.pagination` and
`EuiDataGrid.pagination`.

This caused several other components that were cloning EUI's pagination
type to start throwing type warnings about `pageSize` being optional.
Where I came across these errors, I modified the extended types to
require `pageSize`. These types and their usages may end up changing
again in any case once the Shared UX team looks into
#56406.

---

## [`87.1.0`](https://github.com/elastic/eui/tree/v87.1.0)

- Updated the underlying library powering `EuiAutoSizer`. This primarily
affects typing around the `disableHeight` and `disableWidth` props
([#6798](elastic/eui#6798))
- Added new `EuiAutoSize`, `EuiAutoSizeHorizontal`, and
`EuiAutoSizeVertical` types to support `EuiAutoSizer`'s now-stricter
typing ([#6798](elastic/eui#6798))
- Updated `EuiDatePickerRange` to support `compressed` display
([#7058](elastic/eui#7058))
- Updated `EuiFlyoutBody` with a new `scrollableTabIndex` prop
([#7061](elastic/eui#7061))
- Added a new `panelMinWidth` prop to `EuiInputPopover`
([#7071](elastic/eui#7071))
- Added a new `inputPopoverProps` prop for `EuiRange`s and
`EuiDualRange`s with `showInput="inputWithPopover"` set
([#7082](elastic/eui#7082))

**Bug fixes**

- Fixed `EuiToolTip` overriding instead of merging its
`aria-describedby` tooltip ID with any existing `aria-describedby`s
([#7055](elastic/eui#7055))
- Fixed `EuiSuperDatePicker`'s `compressed` display
([#7058](elastic/eui#7058))
- Fixed `EuiAccordion` to remove tabbable children from sequential
keyboard navigation when the accordion is closed
([#7064](elastic/eui#7064))
- Fixed `EuiFlyout`s to accept custom `aria-describedby` IDs
([#7065](elastic/eui#7065))

**Accessibility**

- Removed the default `dialog` role and `tabIndex` from push
`EuiFlyout`s. Push flyouts, compared to overlay flyouts, require manual
accessibility management.
([#7065](elastic/eui#7065))

## [`87.0.0`](https://github.com/elastic/eui/tree/v87.0.0)

- Added beta `componentDefaults` prop to `EuiProvider`, which will allow
configuring certain default props globally. This list of components and
defaults is still under consideration.
([#6923](elastic/eui#6923))
- `EuiPortal`'s `insert` prop can now be configured globally via
`EuiProvider.componentDefaults`
([#6941](elastic/eui#6941))
- `EuiFocusTrap`'s `crossFrame` and `gapMode` props can now be
configured globally via `EuiProvider.componentDefaults`
([#6942](elastic/eui#6942))
- `EuiTablePagination`'s `itemsPerPage`, `itemsPerPageOptions`, and
`showPerPageOptions` props can now be configured globally via
`EuiProvider.componentDefaults`
([#6951](elastic/eui#6951))
- `EuiBasicTable`, `EuiInMemoryTable`, and `EuiDataGrid` now allow
`pagination.pageSize` to be undefined. If undefined, `pageSize` defaults
to `EuiTablePagination`'s `itemsPerPage` component default.
([#6993](elastic/eui#6993))
- `EuiBasicTable`, `EuiInMemoryTable`, and `EuiDataGrid`'s
`pagination.pageSizeOptions` will now fall back to
`EuiTablePagination`'s `itemsPerPageOptions` component default.
([#6993](elastic/eui#6993))
- Updated `EuiHeaderLinks`'s `gutterSize` spacings
([#7005](elastic/eui#7005))
- Updated `EuiHeaderAlert`'s stacking styles
([#7005](elastic/eui#7005))
- Added `toolTipProps` to `EuiListGroupItem` that allows customizing
item tooltips. ([#7018](elastic/eui#7018))
- Updated `EuiBreadcrumbs` to support breadcrumbs that toggle popovers
via `popoverContent` and `popoverProps`
([#7031](elastic/eui#7031))
- Improved the contrast ratio of disabled titles within `EuiSteps` and
`EuiStepsHorizontal` to meet WCAG AA guidelines.
([#7032](elastic/eui#7032))
- Updated `EuiSteps` and `EuiStepsHorizontal` to highlight and provide a
more clear visual indication of the current step
([#7048](elastic/eui#7048))

**Bug fixes**

- Single uses of `<EuiHeaderSectionItem side="right" />` now align right
as expected without needing a previous `side="left"` sibling.
([#7005](elastic/eui#7005))
- `EuiPageTemplate` now correctly displays `panelled={true}`
([#7044](elastic/eui#7044))

**Breaking changes**

- `EuiTablePagination`'s default `itemsPerPage` is now `10` (was
previously `50`). This can be configured through
`EuiProvider.componentDefaults`.
([#6993](elastic/eui#6993))
- `EuiTablePagination`'s default `itemsPerPageOptions` is now `[10, 25,
50]` (was previously `[10, 20, 50, 100]`). This can be configured
through `EuiProvider.componentDefaults`.
([#6993](elastic/eui#6993))
- Removed `border` prop from `EuiHeaderSectionItem` (unused since
Amsterdam theme) ([#7005](elastic/eui#7005))
- Removed `borders` object configuration from `EuiHeader.sections`
([#7005](elastic/eui#7005))

**CSS-in-JS conversions**

- Converted `EuiHeaderAlert` to Emotion; Removed unused
`.euiHeaderAlert__dismiss` CSS
([#7005](elastic/eui#7005))
- Converted `EuiHeaderSection`, `EuiHeaderSectionItem`, and
`EuiHeaderSectionItemButton` to Emotion
([#7005](elastic/eui#7005))
- Converted `EuiHeaderLinks` and `EuiHeaderLink` to Emotion; Removed
`$euiHeaderLinksGutterSizes` Sass variables
([#7005](elastic/eui#7005))
- Removed `$euiHeaderBackgroundColor` Sass variable; use
`$euiColorEmptyShade` instead
([#7005](elastic/eui#7005))
- Removed `$euiHeaderChildSize` Sass variable; use `$euiSizeXXL` instead
([#7005](elastic/eui#7005))

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BigFunger BigFunger

Labels
Feature:Add Data Add Data and sample data feature on Home review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BigFunger @Bargs @alt74