Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] PR #6773 to 4.5 #7079

Closed
wants to merge 1 commit into from
Closed

Commits on Apr 27, 2016

  1. Backport PR #6773

    ---------
    
    **Commit 1:**
    [state] add configurable warning level based on url length
    
    * Original sha: 55db90d
    * Authored by spalger <spalger@users.noreply.github.com> on 2016-04-04T21:57:45Z
    
    **Commit 2:**
    [state] add a hard length limit that will start throwing errors
    
    * Original sha: 64699aa
    * Authored by spalger <spalger@users.noreply.github.com> on 2016-04-04T22:14:06Z
    
    **Commit 3:**
    Merge branch 'master' of github.com:elastic/kibana into implement/betterWarningForUrlLength
    
    * Original sha: 4c70d69
    * Authored by spalger <spalger@users.noreply.github.com> on 2016-04-06T07:05:47Z
    
    **Commit 4:**
    [dashboard] cleanup quietly to prevent error
    
    * Original sha: 1dace5c
    * Authored by spalger <spalger@users.noreply.github.com> on 2016-04-06T08:50:55Z
    
    **Commit 5:**
    [errorview] add url overflow display
    
    * Original sha: 8b4ebf5
    * Authored by spalger <spalger@users.noreply.github.com> on 2016-04-06T08:51:47Z
    
    **Commit 6:**
    [errorview] persist the overflow url so that refresh works
    
    * Original sha: e308db9
    * Authored by spalger <spalger@users.noreply.github.com> on 2016-04-06T09:05:13Z
    
    **Commit 7:**
    Merge branch 'master' of github.com:elastic/kibana into implement/betterWarningForUrlLength
    
    * Original sha: 121e4f2
    * Authored by spalger <email@spalger.com> on 2016-04-15T18:49:12Z
    
    **Commit 8:**
    [config] remove url limit config, it should adapt automatically
    
    * Original sha: 281b38b
    * Authored by spalger <email@spalger.com> on 2016-04-15T23:38:05Z
    
    **Commit 9:**
    [chrome] rework url overflow detection
    
    The previous version of this pr relied on the State service to catch times when the URL would grow out of control. While overflows will commonly occur in the State service, this didn't handle urls that were navigated to using a link. They worked because the state service would eventually be called, but the failure was unexpected and required interaction to trigger.
    
    This new approach does the checking at a higher level, in the chrome.
    
    We also removed the `url:limit` configuration value in favor of browser detection (I was not able to find or come up with a way to quietly and quickly feature detect this). The new limits are 2000 characters for IE and 25000 for all other browsers.
    
    * Original sha: 116521c
    * Authored by spalger <email@spalger.com> on 2016-04-15T23:40:18Z
    
    **Commit 10:**
    Merge branch 'master' of github.com:elastic/kibana into implement/betterWarningForUrlLength
    
    * Original sha: aa030d7
    * Authored by spalger <email@spalger.com> on 2016-04-26T16:51:22Z
    
    **Commit 11:**
    [ui/config] remove unused default
    
    * Original sha: b333c51
    * Authored by spalger <email@spalger.com> on 2016-04-26T16:52:29Z
    
    **Commit 12:**
    Merge branch 'master' of github.com:elastic/kibana into implement/betterWarningForUrlLength
    
    * Original sha: 133d7e5
    * Authored by spalger <email@spalger.com> on 2016-04-27T23:17:44Z
    
    **Commit 13:**
    [urlOverflow] assign magic numbers to variables
    
    * Original sha: 8b97881
    * Authored by spalger <email@spalger.com> on 2016-04-27T23:24:17Z
    elastic-jasper committed Apr 27, 2016
    Configuration menu
    Copy the full SHA
    e7233a5 View commit details
    Browse the repository at this point in the history