-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Add name
to Observer
type
#72110
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport elastic#72078 is failing because of the type check because `observer.name` is not defined. Not sure why this wasn't a problem on master, but adding it here so I can include it.
smith
added
release_note:skip
Skip the PR/issue when compiling release notes
v7.9.0
labels
Jul 16, 2020
Pinging @elastic/apm-ui (Team:apm) |
ogupte
approved these changes
Jul 16, 2020
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-oss-agent / Firefox UI Functional Tests.test/functional/apps/visualize/input_control_vis/chained_controls·js.visualize app input controls chained controls should disable child control when parent control is not setStandard Out
Stack Trace
Build metrics
To update your PR or re-run it, just comment with: |
smith
added a commit
to smith/kibana
that referenced
this pull request
Jul 16, 2020
Backport elastic#72078 is failing because of the type check because `observer.name` is not defined. Not sure why this wasn't a problem on master, but adding it here so I can include it.
smith
added a commit
to smith/kibana
that referenced
this pull request
Jul 16, 2020
Backport elastic#72078 is failing because of the type check because `observer.name` is not defined. Not sure why this wasn't a problem on master, but adding it here so I can include it.
smith
added a commit
that referenced
this pull request
Jul 16, 2020
smith
added a commit
that referenced
this pull request
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:APM
All issues that need APM UI Team support
v7.9.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #72078 is failing because of the type check because
observer.name
is not defined. Not sure why this wasn't a problem on master, but adding it here so I can include it.