Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Add name to Observer type #72110

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Conversation

smith
Copy link
Contributor

@smith smith commented Jul 16, 2020

Backport #72078 is failing because of the type check because observer.name is not defined. Not sure why this wasn't a problem on master, but adding it here so I can include it.

Backport elastic#72078 is failing because of the type check because `observer.name` is not defined. Not sure why this wasn't a problem on master, but adding it here so I can include it.
@smith smith added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 16, 2020
@smith smith requested a review from a team as a code owner July 16, 2020 17:11
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jul 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-oss-agent / Firefox UI Functional Tests.test/functional/apps/visualize/input_control_vis/chained_controls·js.visualize app input controls chained controls should disable child control when parent control is not set

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 3 times on tracked branches: https://github.com/elastic/kibana/issues/68472

[00:00:00]       │
[00:12:08]         └-: visualize app
[00:12:08]           └-> "before all" hook
[00:12:08]           └-> "before all" hook
[00:12:08]             │ debg Starting visualize before method
[00:12:08]             │ info [logstash_functional] Loading "mappings.json"
[00:12:08]             │ info [logstash_functional] Loading "data.json.gz"
[00:12:08]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] [logstash-2015.09.22] creating index, cause [api], templates [], shards [1]/[0]
[00:12:08]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.22][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.22][0]]"
[00:12:08]             │ info [logstash_functional] Created index "logstash-2015.09.22"
[00:12:08]             │ debg [logstash_functional] "logstash-2015.09.22" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:12:08]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] [logstash-2015.09.20] creating index, cause [api], templates [], shards [1]/[0]
[00:12:08]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.20][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.20][0]]"
[00:12:08]             │ info [logstash_functional] Created index "logstash-2015.09.20"
[00:12:08]             │ debg [logstash_functional] "logstash-2015.09.20" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:12:08]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] [logstash-2015.09.21] creating index, cause [api], templates [], shards [1]/[0]
[00:12:08]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.21][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.21][0]]"
[00:12:08]             │ info [logstash_functional] Created index "logstash-2015.09.21"
[00:12:08]             │ debg [logstash_functional] "logstash-2015.09.21" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:12:18]             │ info progress: 13244
[00:12:19]             │ info [logstash_functional] Indexed 4633 docs into "logstash-2015.09.22"
[00:12:19]             │ info [logstash_functional] Indexed 4757 docs into "logstash-2015.09.20"
[00:12:19]             │ info [logstash_functional] Indexed 4614 docs into "logstash-2015.09.21"
[00:12:19]             │ info [long_window_logstash] Loading "mappings.json"
[00:12:19]             │ info [long_window_logstash] Loading "data.json.gz"
[00:12:19]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] [long-window-logstash-0] creating index, cause [api], templates [], shards [1]/[0]
[00:12:19]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[long-window-logstash-0][0]]])." previous.health="YELLOW" reason="shards started [[long-window-logstash-0][0]]"
[00:12:19]             │ info [long_window_logstash] Created index "long-window-logstash-0"
[00:12:19]             │ debg [long_window_logstash] "long-window-logstash-0" settings {"index":{"analysis":{"analyzer":{"makelogs_url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:12:29]             │ info progress: 11695
[00:12:31]             │ info [long_window_logstash] Indexed 14005 docs into "long-window-logstash-0"
[00:12:31]             │ info [visualize] Loading "mappings.json"
[00:12:31]             │ info [visualize] Loading "data.json"
[00:12:31]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] [.kibana_2/JO_GBgSqQp-JZjEBe9yxjA] deleting index
[00:12:31]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] [.kibana_1/V_NdNGL_TVGQdSBlHAGVPg] deleting index
[00:12:31]             │ info [visualize] Deleted existing index [".kibana_2",".kibana_1"]
[00:12:31]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] [.kibana] creating index, cause [api], templates [], shards [1]/[1]
[00:12:32]             │ info [visualize] Created index ".kibana"
[00:12:32]             │ debg [visualize] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:12:32]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] [.kibana/a_SiRbTFRhWL5ELd0hEUxA] update_mapping [_doc]
[00:12:32]             │ info [visualize] Indexed 12 docs into ".kibana"
[00:12:32]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] [.kibana/a_SiRbTFRhWL5ELd0hEUxA] update_mapping [_doc]
[00:12:32]             │ debg Migrating saved objects
[00:12:32]             │ proc [kibana]   log   [17:37:22.647] [info][savedobjects-service] Creating index .kibana_2.
[00:12:32]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1]
[00:12:32]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] updating number_of_replicas to [0] for indices [.kibana_2]
[00:12:32]             │ proc [kibana]   log   [17:37:22.698] [info][savedobjects-service] Reindexing .kibana to .kibana_1
[00:12:32]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1]
[00:12:32]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] updating number_of_replicas to [0] for indices [.kibana_1]
[00:12:32]             │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] 9955 finished with response BulkByScrollResponse[took=29.2ms,timed_out=false,sliceId=null,updated=0,created=12,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:12:32]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] [.kibana/a_SiRbTFRhWL5ELd0hEUxA] deleting index
[00:12:32]             │ proc [kibana]   log   [17:37:23.036] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:12:32]             │ proc [kibana]   log   [17:37:23.056] [error][savedobjects-service] Error: Unable to migrate the corrupt Saved Object document index-pattern:test_index*. To prevent Kibana from performing a migration on every restart, please delete or fix this document by ensuring that the namespace and type in the document's id matches the values in the namespace and type fields.
[00:12:32]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] [.kibana_2/O5XuuGcaTgKtoExG4Qs2-Q] update_mapping [_doc]
[00:12:32]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] [.kibana_2/O5XuuGcaTgKtoExG4Qs2-Q] update_mapping [_doc]
[00:12:32]             │ proc [kibana]   log   [17:37:23.138] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:12:32]             │ proc [kibana]   log   [17:37:23.183] [info][savedobjects-service] Finished in 538ms.
[00:12:32]             │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:12:32]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-debian-tests-xl-1594919496804048454] [.kibana_2/O5XuuGcaTgKtoExG4Qs2-Q] update_mapping [_doc]
[00:12:34]             │ debg replacing kibana config doc: {"defaultIndex":"logstash-*","format:bytes:defaultPattern":"0,0.[000]b"}
[00:12:35]           └-: 
[00:12:35]             └-> "before all" hook
[00:12:35]             └-: input controls
[00:12:35]               └-> "before all" hook
[00:12:35]               └-: chained controls
[00:12:35]                 └-> "before all" hook
[00:12:35]                 └-> "before all" hook
[00:12:35]                   │ debg navigating to visualize url: http://localhost:6111/app/visualize#/
[00:12:35]                   │ debg navigate to: http://localhost:6111/app/visualize#/
[00:12:35]                   │ debg browser[log] "^ A single error about an inline script not firing due to content security policy is expected!"
[00:12:35]                   │ debg ... sleep(700) start
[00:12:36]                   │ debg ... sleep(700) end
[00:12:36]                   │ debg returned from get, calling refresh
[00:12:37]                   │ debg browser[info] "INFO: 2020-07-16T17:37:27Z
[00:12:37]                   │        Adding connection to http://localhost:6111/elasticsearch
[00:12:37]                   │
[00:12:37]                   │      "
[00:12:37]                   │ERROR browser[error] (new TypeError("NetworkError when attempting to fetch resource.", ""))
[00:12:37]                   │ debg browser[log] "^ A single error about an inline script not firing due to content security policy is expected!"
[00:12:37]                   │ debg currentUrl = http://localhost:6111/app/visualize#/
[00:12:37]                   │          appUrl = http://localhost:6111/app/visualize#/
[00:12:37]                   │ debg TestSubjects.find(kibanaChrome)
[00:12:37]                   │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:12:39]                   │ debg browser[info] "INFO: 2020-07-16T17:37:29Z
[00:12:39]                   │        Adding connection to http://localhost:6111/elasticsearch
[00:12:39]                   │
[00:12:39]                   │      "
[00:12:40]                   │ debg ... sleep(501) start
[00:12:40]                   │ debg ... sleep(501) end
[00:12:40]                   │ debg in navigateTo url = http://localhost:6111/app/visualize#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))
[00:12:40]                   │ debg --- retry.try error: URL changed, waiting for it to settle
[00:12:41]                   │ debg ... sleep(501) start
[00:12:41]                   │ debg ... sleep(501) end
[00:12:41]                   │ debg in navigateTo url = http://localhost:6111/app/visualize#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))
[00:12:41]                   │ debg TestSubjects.exists(statusPageContainer)
[00:12:41]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:12:44]                   │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:12:44]                   │ debg TestSubjects.click(visListingTitleLink-chained-input-control)
[00:12:44]                   │ debg Find.clickByCssSelector('[data-test-subj="visListingTitleLink-chained-input-control"]') with timeout=20000
[00:12:44]                   │ debg Find.findByCssSelector('[data-test-subj="visListingTitleLink-chained-input-control"]') with timeout=20000
[00:12:44]                   │ debg isGlobalLoadingIndicatorVisible
[00:12:44]                   │ debg TestSubjects.exists(globalLoadingIndicator)
[00:12:44]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:12:44]                   │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:12:44]                   │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:12:44]                 └-> should disable child control when parent control is not set
[00:12:44]                   └-> "before each" hook: global before each
[00:12:44]                   │ debg comboBox.getOptionsList, comboBoxSelector: listControlSelect0
[00:12:44]                   │ debg TestSubjects.find(listControlSelect0)
[00:12:44]                   │ debg Find.findByCssSelector('[data-test-subj="listControlSelect0"]') with timeout=10000
[00:12:45]                   │ debg TestSubjects.click(listControlSelect0)
[00:12:45]                   │ debg Find.clickByCssSelector('[data-test-subj="listControlSelect0"]') with timeout=10000
[00:12:45]                   │ debg Find.findByCssSelector('[data-test-subj="listControlSelect0"]') with timeout=10000
[00:12:47]                   │ debg TestSubjects.exists(~comboBoxOptionsList)
[00:12:47]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="comboBoxOptionsList"]') with timeout=2500
[00:12:47]                   │ debg TestSubjects.find(~comboBoxOptionsList)
[00:12:47]                   │ debg Find.findByCssSelector('[data-test-subj~="comboBoxOptionsList"]') with timeout=10000
[00:12:47]                   │ warn WebElementWrapper.getVisibleText: The element reference of <div class="euiPanel euiComboBoxOptionsList euiComboBoxOptionsList--bottom"> is stale; either the element is no longer attached to the DOM, it is not in the current frame context, or the document has been refreshed
[00:12:47]                   │ debg finding element 'By(css selector, [data-test-subj~="comboBoxOptionsList"])' again, 2 attempts left
[00:12:57]                   │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/visualize app  input controls chained controls should disable child control when parent control is not set.png"
[00:12:58]                   │ info Current URL is: http://localhost:6111/app/visualize#/edit/68305470-87bc-11e9-a991-3b492a7c3e09?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(filters:!(),linked:!f,query:(language:kuery,query:%27%27),uiState:(),vis:(aggs:!(),params:(controls:!((fieldName:geo.src,id:%271559757816862%27,indexPattern:%27logstash-*%27,label:%27%27,options:(dynamicOptions:!t,multiselect:!t,order:desc,size:5,type:terms),parent:%27%27,type:list),(fieldName:clientip,id:%271559757836347%27,indexPattern:%27logstash-*%27,label:%27%27,options:(dynamicOptions:!t,multiselect:!t,order:desc,size:5,type:terms),parent:%271559757816862%27,type:list)),pinFilters:!f,updateFiltersOnChange:!f,useTimeFilter:!f),title:%27chained%20input%20control%27,type:input_control_vis))
[00:12:58]                   │ info Saving page source to: /dev/shm/workspace/kibana/test/functional/failure_debug/html/visualize app  input controls chained controls should disable child control when parent control is not set.html
[00:12:58]                   └- ✖ fail: visualize app  input controls chained controls should disable child control when parent control is not set
[00:12:58]                   │      NoSuchElementError: Unable to locate element: [data-test-subj~="comboBoxOptionsList"]
[00:12:58]                   │       at Object.throwDecodedError (node_modules/selenium-webdriver/lib/error.js:550:15)
[00:12:58]                   │       at parseHttpResponse (node_modules/selenium-webdriver/lib/http.js:565:13)
[00:12:58]                   │       at Executor.execute (node_modules/selenium-webdriver/lib/http.js:491:26)
[00:12:58]                   │       at process._tickCallback (internal/process/next_tick.js:68:7)
[00:12:58]                   │ 
[00:12:58]                   │ 

Stack Trace

{ NoSuchElementError: Unable to locate element: [data-test-subj~="comboBoxOptionsList"]
    at Object.throwDecodedError (node_modules/selenium-webdriver/lib/error.js:550:15)
    at parseHttpResponse (node_modules/selenium-webdriver/lib/http.js:565:13)
    at Executor.execute (node_modules/selenium-webdriver/lib/http.js:491:26)
    at process._tickCallback (internal/process/next_tick.js:68:7)
  name: 'NoSuchElementError',
  remoteStacktrace:
   'WebDriverError@chrome://marionette/content/error.js:175:5\nNoSuchElementError@chrome://marionette/content/error.js:387:5\nelement.find/</<@chrome://marionette/content/element.js:331:16\n' }

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 26a0cf5 into elastic:master Jul 16, 2020
@smith smith deleted the nls/observer-name branch July 16, 2020 18:58
smith added a commit to smith/kibana that referenced this pull request Jul 16, 2020
Backport elastic#72078 is failing because of the type check because `observer.name` is not defined. Not sure why this wasn't a problem on master, but adding it here so I can include it.
smith added a commit to smith/kibana that referenced this pull request Jul 16, 2020
Backport elastic#72078 is failing because of the type check because `observer.name` is not defined. Not sure why this wasn't a problem on master, but adding it here so I can include it.
smith added a commit that referenced this pull request Jul 16, 2020
Backport #72078 is failing because of the type check because `observer.name` is not defined. Not sure why this wasn't a problem on master, but adding it here so I can include it.
smith added a commit that referenced this pull request Jul 16, 2020
Backport #72078 is failing because of the type check because `observer.name` is not defined. Not sure why this wasn't a problem on master, but adding it here so I can include it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants