Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Apply minimal mappings to es_archive monitoring data #76008

Merged
merged 2 commits into from
Aug 31, 2020
Merged

[Monitoring] Apply minimal mappings to es_archive monitoring data #76008

merged 2 commits into from
Aug 31, 2020

Conversation

chrisronline
Copy link
Contributor

Relates to #73864

This PR takes the work done in #73864 (comment) to determine the minimal set of necessary mappings and apply them to the mappings used in our functional tests. This serves two main purposes:

  1. Verifies the mapping changes are indeed correct, assuming the functional tests all pass
  2. Reduces the footprint of these archive files in the Kibana repo

@chrisronline chrisronline added review Team:Monitoring Stack Monitoring team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Aug 26, 2020
@chrisronline chrisronline self-assigned this Aug 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@chrisronline chrisronline mentioned this pull request Aug 26, 2020
Open
14 tasks
@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

igoristic
igoristic approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go, so long as the tests still pass 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit 50ce634 into elastic:master Aug 31, 2020
@chrisronline chrisronline deleted the monitoring/mappings branch August 31, 2020 16:58
chrisronline added a commit to chrisronline/kibana that referenced this pull request Aug 31, 2020
@chrisronline
Reduce mappings (elastic#76008)
be0c59b 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/test/functional/es_archives/monitoring/apm/mappings.json
#	x-pack/test/functional/es_archives/monitoring/basic_6.3.x/mappings.json
#	x-pack/test/functional/es_archives/monitoring/beats-with-restarted-instance/mappings.json
#	x-pack/test/functional/es_archives/monitoring/beats/mappings.json
#	x-pack/test/functional/es_archives/monitoring/ccr/mappings.json
#	x-pack/test/functional/es_archives/monitoring/logstash-pipelines/mappings.json
#	x-pack/test/functional/es_archives/monitoring/multi-basic/mappings.json
#	x-pack/test/functional/es_archives/monitoring/multicluster/mappings.json
#	x-pack/test/functional/es_archives/monitoring/singlecluster-basic-beats/mappings.json
#	x-pack/test/functional/es_archives/monitoring/singlecluster-green-gold/mappings.json
#	x-pack/test/functional/es_archives/monitoring/singlecluster-green-platinum/mappings.json
#	x-pack/test/functional/es_archives/monitoring/singlecluster-green-trial-two-nodes-one-cgrouped/mappings.json
#	x-pack/test/functional/es_archives/monitoring/singlecluster-red-platinum/mappings.json
#	x-pack/test/functional/es_archives/monitoring/singlecluster-three-nodes-shard-relocation/mappings.json
#	x-pack/test/functional/es_archives/monitoring/singlecluster-yellow-basic/mappings.json
#	x-pack/test/functional/es_archives/monitoring/singlecluster-yellow-platinum--with-10-alerts/mappings.json
#	x-pack/test/functional/es_archives/monitoring/singlecluster-yellow-platinum/mappings.json
#	x-pack/test/functional/es_archives/monitoring/standalone_cluster/mappings.json
@chrisronline chrisronline mentioned this pull request Aug 31, 2020
Merged
chrisronline added a commit that referenced this pull request Aug 31, 2020
@chrisronline
Reduce mappings (#76008) (#76309)
ae3a590 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/test/functional/es_archives/monitoring/apm/mappings.json
#	x-pack/test/functional/es_archives/monitoring/basic_6.3.x/mappings.json
#	x-pack/test/functional/es_archives/monitoring/beats-with-restarted-instance/mappings.json
#	x-pack/test/functional/es_archives/monitoring/beats/mappings.json
#	x-pack/test/functional/es_archives/monitoring/ccr/mappings.json
#	x-pack/test/functional/es_archives/monitoring/logstash-pipelines/mappings.json
#	x-pack/test/functional/es_archives/monitoring/multi-basic/mappings.json
#	x-pack/test/functional/es_archives/monitoring/multicluster/mappings.json
#	x-pack/test/functional/es_archives/monitoring/singlecluster-basic-beats/mappings.json
#	x-pack/test/functional/es_archives/monitoring/singlecluster-green-gold/mappings.json
#	x-pack/test/functional/es_archives/monitoring/singlecluster-green-platinum/mappings.json
#	x-pack/test/functional/es_archives/monitoring/singlecluster-green-trial-two-nodes-one-cgrouped/mappings.json
#	x-pack/test/functional/es_archives/monitoring/singlecluster-red-platinum/mappings.json
#	x-pack/test/functional/es_archives/monitoring/singlecluster-three-nodes-shard-relocation/mappings.json
#	x-pack/test/functional/es_archives/monitoring/singlecluster-yellow-basic/mappings.json
#	x-pack/test/functional/es_archives/monitoring/singlecluster-yellow-platinum--with-10-alerts/mappings.json
#	x-pack/test/functional/es_archives/monitoring/singlecluster-yellow-platinum/mappings.json
#	x-pack/test/functional/es_archives/monitoring/standalone_cluster/mappings.json
@chrisronline
Copy link
Contributor Author

Backport:

7.x: ae3a590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igoristic igoristic igoristic approved these changes

Assignees

@chrisronline chrisronline

Labels
release_note:skip Skip the PR/issue when compiling release notes review Team:Monitoring Stack Monitoring team v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisronline @elasticmachine @kibanamachine @igoristic