-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Read from metricbeat-* for ES node_stats #76015
Merged
chrisronline
merged 5 commits into
elastic:master
from
chrisronline:monitoring/ecs_node_stats
Sep 8, 2020
Merged
[Monitoring] Read from metricbeat-* for ES node_stats #76015
chrisronline
merged 5 commits into
elastic:master
from
chrisronline:monitoring/ecs_node_stats
Sep 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/stack-monitoring (Team:Monitoring) |
chrisronline
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
Aug 26, 2020
@elasticmachine merge upstream |
14 tasks
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
igoristic
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works as expected. Great job!
Backport: 7.x: 8bde2b3 |
This was referenced Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
review
Team:Monitoring
Stack Monitoring team
v7.10.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #73864
This PR adapts the UI code to read from
metricbeat-*
indices for queries against ESnode_stats
type monitoring documents while preserving existing functionality. This work is based off the changes done on the beats side (elastic/beats#19747) and must be used to test this PR. This PR should work outside of the beats PR, in that existing functionality shouldn't break at all (so it's safe to merge this to master without the beats PR going into master)This is the first PR of several that will adapt the UI code to read from all monitoring document types, and as such, it comes with a little more code changes, mainly the changes necessary to ensure all queries start searching against
metricbeat-*
as well as handling the fact thattype
is not aliased.To test:
elasticsearch-xpack
module and start Metricbeat.node_stats
in the response of this query:node_stats
in the response to this query: