Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections] Removes ML Job Settings SIEM copy and fixes link to ML app for creating custom jobs #76595

Merged
merged 2 commits into from
Sep 3, 2020
Merged

[Security Solution][Detections] Removes ML Job Settings SIEM copy and fixes link to ML app for creating custom jobs #76595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a47e846
Removes remaining SIEM copy and fixes link to ml app for creating cus…
spong Sep 3, 2020
b623908
Update jobs_table.tsx
spong Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...ion/public/common/components/ml_popover/jobs_table/__snapshots__/jobs_table.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions ...k/plugins/security_solution/public/common/components/ml_popover/jobs_table/jobs_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export const JobsTableComponent = ({ isLoading, jobs, onJobStateChange }: JobTab
columns={getJobsTableColumns(isLoading, onJobStateChange, basePath)}
items={getPaginatedItems(jobs, pageIndex, pageSize)}
loading={isLoading}
noItemsMessage={<NoItemsMessage />}
noItemsMessage={<NoItemsMessage basePath={basePath} />}
pagination={pagination}
responsive={false}
onChange={({ page }: { page: { index: number } }) => {
Expand All @@ -141,13 +141,13 @@ export const JobsTable = React.memo(JobsTableComponent);

JobsTable.displayName = 'JobsTable';

export const NoItemsMessage = React.memo(() => (
export const NoItemsMessage = React.memo(({ basePath }: { basePath: string }) => (
<EuiEmptyPrompt
title={<h3>{i18n.NO_ITEMS_TEXT}</h3>}
titleSize="xs"
actions={
<EuiButton
href="ml#/jobs/new_job/step/index_or_search"
href={`${basePath}/app/ml#/jobs/new_job/step/index_or_search`}
iconType="popout"
iconSide="right"
size="s"
Expand Down
2 changes: 1 addition & 1 deletion .../plugins/security_solution/public/common/components/ml_popover/jobs_table/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const COLUMN_RUN_JOB = i18n.translate(
export const NO_ITEMS_TEXT = i18n.translate(
'xpack.securitySolution.components.mlPopup.jobsTable.noItemsDescription',
{
defaultMessage: 'No SIEM Machine Learning jobs found',
defaultMessage: 'No Security Machine Learning jobs found',
}
);

Expand Down