From 4140f2d2a8fe13e8460dc21216cd1219559d2c3a Mon Sep 17 00:00:00 2001
From: Garrett Spong <spong@users.noreply.github.com>
Date: Thu, 3 Sep 2020 16:16:08 -0600
Subject: [PATCH] [Security Solution][Detections] Removes ML Job Settings SIEM
 copy and fixes link to ML app for creating custom jobs (#76595)

## Summary

Resolves https://github.com/elastic/security-team/issues/199

Removes remaining SIEM copy and fixes link to ML app for creating custom jobs

<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/92073438-e017d600-ed70-11ea-9827-7b5c9ffab7b1.gif" />
</p>



### Checklist

Delete any items that are not applicable to this PR.

- [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
---
 .../jobs_table/__snapshots__/jobs_table.test.tsx.snap       | 6 +++++-
 .../common/components/ml_popover/jobs_table/jobs_table.tsx  | 6 +++---
 .../common/components/ml_popover/jobs_table/translations.ts | 2 +-
 3 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/x-pack/plugins/security_solution/public/common/components/ml_popover/jobs_table/__snapshots__/jobs_table.test.tsx.snap b/x-pack/plugins/security_solution/public/common/components/ml_popover/jobs_table/__snapshots__/jobs_table.test.tsx.snap
index 60088a77878ad..a40ccfa7cd1b5 100644
--- a/x-pack/plugins/security_solution/public/common/components/ml_popover/jobs_table/__snapshots__/jobs_table.test.tsx.snap
+++ b/x-pack/plugins/security_solution/public/common/components/ml_popover/jobs_table/__snapshots__/jobs_table.test.tsx.snap
@@ -100,7 +100,11 @@ exports[`JobsTableComponent renders correctly against snapshot 1`] = `
     ]
   }
   loading={true}
-  noItemsMessage={<Memo(NoItemsMessage) />}
+  noItemsMessage={
+    <Memo(NoItemsMessage)
+      basePath="/test/base/path"
+    />
+  }
   onChange={[Function]}
   pagination={
     Object {
diff --git a/x-pack/plugins/security_solution/public/common/components/ml_popover/jobs_table/jobs_table.tsx b/x-pack/plugins/security_solution/public/common/components/ml_popover/jobs_table/jobs_table.tsx
index be911a1cd8537..1e9e689dcd6ff 100644
--- a/x-pack/plugins/security_solution/public/common/components/ml_popover/jobs_table/jobs_table.tsx
+++ b/x-pack/plugins/security_solution/public/common/components/ml_popover/jobs_table/jobs_table.tsx
@@ -125,7 +125,7 @@ export const JobsTableComponent = ({ isLoading, jobs, onJobStateChange }: JobTab
       columns={getJobsTableColumns(isLoading, onJobStateChange, basePath)}
       items={getPaginatedItems(jobs, pageIndex, pageSize)}
       loading={isLoading}
-      noItemsMessage={<NoItemsMessage />}
+      noItemsMessage={<NoItemsMessage basePath={basePath} />}
       pagination={pagination}
       responsive={false}
       onChange={({ page }: { page: { index: number } }) => {
@@ -141,13 +141,13 @@ export const JobsTable = React.memo(JobsTableComponent);
 
 JobsTable.displayName = 'JobsTable';
 
-export const NoItemsMessage = React.memo(() => (
+export const NoItemsMessage = React.memo(({ basePath }: { basePath: string }) => (
   <EuiEmptyPrompt
     title={<h3>{i18n.NO_ITEMS_TEXT}</h3>}
     titleSize="xs"
     actions={
       <EuiButton
-        href="ml#/jobs/new_job/step/index_or_search"
+        href={`${basePath}/app/ml#/jobs/new_job/step/index_or_search`}
         iconType="popout"
         iconSide="right"
         size="s"
diff --git a/x-pack/plugins/security_solution/public/common/components/ml_popover/jobs_table/translations.ts b/x-pack/plugins/security_solution/public/common/components/ml_popover/jobs_table/translations.ts
index 12ca5df7fe97f..bcde39355a21d 100644
--- a/x-pack/plugins/security_solution/public/common/components/ml_popover/jobs_table/translations.ts
+++ b/x-pack/plugins/security_solution/public/common/components/ml_popover/jobs_table/translations.ts
@@ -30,7 +30,7 @@ export const COLUMN_RUN_JOB = i18n.translate(
 export const NO_ITEMS_TEXT = i18n.translate(
   'xpack.securitySolution.components.mlPopup.jobsTable.noItemsDescription',
   {
-    defaultMessage: 'No SIEM Machine Learning jobs found',
+    defaultMessage: 'No Security Machine Learning jobs found',
   }
 );