Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Update WS Overview logic to use new config data #77122

Merged
merged 7 commits into from
Sep 10, 2020
Merged

[Enterprise Search] Update WS Overview logic to use new config data #77122

merged 7 commits into from
Sep 10, 2020

Commits on Sep 9, 2020

  1. Update AppLogic to use new data structure

    @scottybollinger
    scottybollinger committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    1f0a043 View commit details
    Browse the repository at this point in the history

  2. Update components to use AppLogic

    @scottybollinger
    scottybollinger committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    96f1208 View commit details
    Browse the repository at this point in the history

  3. Remove unused props from logic file

    @scottybollinger
    scottybollinger committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    aa672db View commit details
    Browse the repository at this point in the history

  4. Fix failing tests

    @scottybollinger
    scottybollinger committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    c57ca47 View commit details
    Browse the repository at this point in the history

  5. Add tests to get 100% converage 

    The test added for app_logic will never happen but hey, 100 is 100.

Also added test to recent_activity for 100% coverage
    @scottybollinger
    scottybollinger committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    b5e728a View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2020

  1. Use non-null assertion operator in logic file 

    TIL this is a thing
    @scottybollinger
    scottybollinger committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    81b908c View commit details
    Browse the repository at this point in the history

  2. Remove test for undefined

    @scottybollinger
    scottybollinger committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    0d5c08c View commit details
    Browse the repository at this point in the history