[Discover] Experimental usage of ES fields API - wildcard fields #77722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-19-use-es-fields-api
…-19-use-es-fields-api
…-19-use-es-fields-api
|
closing cause it was just an experiment |
kertal
commented
Oct 12, 2020
Comment on lines
+945
to
+946
| .setField('fieldsApi', ['*']) | ||
| .setField('source', false) |
There was a problem hiding this comment.
@majagrubic all fields are requested instead of source
There was a problem hiding this comment.
so it's the opposite of #75407 where _source is requested and selected fields are added to the requests, here no additional request is needed when columns are added to the table
kertal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simular to #75407 with the difference to fetch all fields via wildcard and skipping
_source.Checklist
Delete any items that are not applicable to this PR.
For maintainers