Enable non-match queries in custom filters #8048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filterManager.add assumes that if it finds a filter that has a query prop, then it must also have a match clause contained in that query. User created custom filters may use term queries, range queries and the like. Once you've added any filters without a match clause like that, you can no longer add new filters by clicking the "add filter" icon next to a field in the results. Instead you'll get an error that says "Cannot read property '<your-prop>' of undefined" when filterManager.add iterates over your custom filter with no match key. Fixes: elastic#7246 Related: elastic#8038
cee-chen
added a commit
that referenced
this pull request
Oct 4, 2024
`v95.12.0`⏩`v96.1.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v96.0.0`](https://github.com/elastic/eui/releases/v96.0.0) - Improved `EuiPageHeader`/`EuiPageTemplate.Header`'s responsive UX: ([#8044](elastic/eui#8044)) - `rightSideItems` are no longer pushed to the side by wide `tabs` content - `rightSideItems` now wrap more responsively at smaller container widths - Updated `EuiDraggable` with a new `usePortal` prop. ([#8048](elastic/eui#8048)) - This prop portals the dragged element to the body, allowing it to escape stacking contexts which prevents buggy drag positioning in e.g. popovers, modals, and flyouts. **Bug fixes** - Fixed `EuiProvider`'s system color mode detection causing errors during server-side rendering ([#8040](elastic/eui#8040)) - Fixed an `EuiDataGrid` rendering bug that was causing bouncing scrollbar issues ([#8041](elastic/eui#8041)) - Fixed `EuiSearchBox` skips input when running with React 18 in Legacy Mode ([#8047](elastic/eui#8047)) **Deprecations** - Deprecated `EuiPopover`'s `hasDragDrop` prop. Use `EuiDraggable`'s new `usePortal` prop instead. ([#8048](elastic/eui#8048)) **Breaking changes** - Removed the following exported `.css` files: ([#8045](elastic/eui#8045)) - `@elastic/eui/dist/eui_theme_light.css` - `@elastic/eui/dist/eui_theme_light.min.css` - `@elastic/eui/dist/eui_theme_dark.css` - `@elastic/eui/dist/eui_theme_dark.min.css` - All EUI components are now on CSS-in-JS. A CSS file/import in consuming applications is no longer needed, and is safe to remove. ([#8045](elastic/eui#8045)) - Removed all `src/theme/legacy` Sass exports ([#8054](elastic/eui#8054)) **CSS-in-JS conversions** - Removed the following component-specific Sass variables: ([#8031](elastic/eui#8031)) - `$euiButtonColorDisabled` - `$euiButtonColorDisabledText` - `$euiButtonColorGhostDisabled` - `$euiButtonFontWeight` - `$euiFormControlIconSizes` - `$euiFormControlLayoutGroupInputHeight` - `$euiFormControlLayoutGroupInputCompressedHeight` - `$euiFormControlLayoutGroupInputCompressedBorderRadius` - `$euiPageSidebarMinWidth` - `$euiPageDefaultMaxWidth` - `$euiPanelPaddingModifiers` - `$euiPanelBorderRadiusModifiers` - `$euiPanelBackgroundColorModifiers` - `$euiRangeTrackColor` - `$euiRangeHighlightColor` - `$euiRangeThumbHeight` - `$euiRangeThumbWidth` - `$euiRangeThumbBorderColor` - `$euiRangeThumbBackgroundColor` - `$euiRangeTrackWidth` - `$euiRangeTrackHeight` - `$euiRangeTrackCompressedHeight` - `$euiRangeTrackBorderWidth` - `$euiRangeTrackBorderColor` - `$euiRangeTrackRadius` - `$euiRangeDisabledOpacity` - `$euiRangeHighlightHeight` - `$euiRangeHighlightCompressedHeight` - `$euiRangeHeight` - `$euiRangeCompressedHeight` - `$euiTooltipAnimations` - `$euiTooltipBackgroundColor` - `$euiTooltipBorderColor` - Removed the following Sass mixins due to low external usage: ([#8031](elastic/eui#8031)) - `euiHoverState` - `euiFocusState` - `euiDisabledState` - `euiInteractiveStates` - `euiFormControlStyle` - `euiFormControlStyleCompressed` - `euiFormControlFocusStyle` - `euiFormControlInvalidStyle` - `euiFormControlDisabledTextStyle` - `euiFormControlDisabledStyle` - `euiFormControlReadOnlyStyle` - `euiFormControlText` - `euiFormControlSize` - `euiFormControlGradient` - `euiFormControlLayoutPadding` - `euiFormControlWithIcon` - `euiFormControlIsLoading` - `euiFormControlSideBorderRadius` - `euiPlaceholderPerBrowser` - `euiHiddenSelectableInput` - `euiLink` - `euiLoadingSpinnerBorderColors` - `euiRangeTrackSize` - `euiRangeTrackPerBrowser` - `euiRangeThumbBorder` - `euiRangeThumbBoxShadow` - `euiRangeThumbFocusBoxShadow` - `euiRangeThumbStyle` - `euiRangeThumbPerBrowser` - `euiRangeThumbFocus` - `euiToolTipAnimation` ## [`v96.1.0`](https://github.com/elastic/eui/releases/v96.1.0) **CSS-in-JS conversions** - Removed the following component-specific Sass mixins: ([#8055](elastic/eui#8055)) - `euiButton` - `euiButtonBase` - `euiButtonFocus` - `euiButtonContent` - `euiButtonContentDisabled` - `euiButtonDefaultStyle` - `euiButtonFillStyle` - `euiPanel` - `euiFormControlDefaultShadow` - `euiToolTipTitle`
cee-chen
added a commit
to cee-chen/kibana
that referenced
this pull request
Oct 4, 2024
`v95.12.0`⏩`v96.1.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v96.0.0`](https://github.com/elastic/eui/releases/v96.0.0) - Improved `EuiPageHeader`/`EuiPageTemplate.Header`'s responsive UX: ([elastic#8044](elastic/eui#8044)) - `rightSideItems` are no longer pushed to the side by wide `tabs` content - `rightSideItems` now wrap more responsively at smaller container widths - Updated `EuiDraggable` with a new `usePortal` prop. ([elastic#8048](elastic/eui#8048)) - This prop portals the dragged element to the body, allowing it to escape stacking contexts which prevents buggy drag positioning in e.g. popovers, modals, and flyouts. **Bug fixes** - Fixed `EuiProvider`'s system color mode detection causing errors during server-side rendering ([elastic#8040](elastic/eui#8040)) - Fixed an `EuiDataGrid` rendering bug that was causing bouncing scrollbar issues ([elastic#8041](elastic/eui#8041)) - Fixed `EuiSearchBox` skips input when running with React 18 in Legacy Mode ([elastic#8047](elastic/eui#8047)) **Deprecations** - Deprecated `EuiPopover`'s `hasDragDrop` prop. Use `EuiDraggable`'s new `usePortal` prop instead. ([elastic#8048](elastic/eui#8048)) **Breaking changes** - Removed the following exported `.css` files: ([elastic#8045](elastic/eui#8045)) - `@elastic/eui/dist/eui_theme_light.css` - `@elastic/eui/dist/eui_theme_light.min.css` - `@elastic/eui/dist/eui_theme_dark.css` - `@elastic/eui/dist/eui_theme_dark.min.css` - All EUI components are now on CSS-in-JS. A CSS file/import in consuming applications is no longer needed, and is safe to remove. ([elastic#8045](elastic/eui#8045)) - Removed all `src/theme/legacy` Sass exports ([elastic#8054](elastic/eui#8054)) **CSS-in-JS conversions** - Removed the following component-specific Sass variables: ([elastic#8031](elastic/eui#8031)) - `$euiButtonColorDisabled` - `$euiButtonColorDisabledText` - `$euiButtonColorGhostDisabled` - `$euiButtonFontWeight` - `$euiFormControlIconSizes` - `$euiFormControlLayoutGroupInputHeight` - `$euiFormControlLayoutGroupInputCompressedHeight` - `$euiFormControlLayoutGroupInputCompressedBorderRadius` - `$euiPageSidebarMinWidth` - `$euiPageDefaultMaxWidth` - `$euiPanelPaddingModifiers` - `$euiPanelBorderRadiusModifiers` - `$euiPanelBackgroundColorModifiers` - `$euiRangeTrackColor` - `$euiRangeHighlightColor` - `$euiRangeThumbHeight` - `$euiRangeThumbWidth` - `$euiRangeThumbBorderColor` - `$euiRangeThumbBackgroundColor` - `$euiRangeTrackWidth` - `$euiRangeTrackHeight` - `$euiRangeTrackCompressedHeight` - `$euiRangeTrackBorderWidth` - `$euiRangeTrackBorderColor` - `$euiRangeTrackRadius` - `$euiRangeDisabledOpacity` - `$euiRangeHighlightHeight` - `$euiRangeHighlightCompressedHeight` - `$euiRangeHeight` - `$euiRangeCompressedHeight` - `$euiTooltipAnimations` - `$euiTooltipBackgroundColor` - `$euiTooltipBorderColor` - Removed the following Sass mixins due to low external usage: ([elastic#8031](elastic/eui#8031)) - `euiHoverState` - `euiFocusState` - `euiDisabledState` - `euiInteractiveStates` - `euiFormControlStyle` - `euiFormControlStyleCompressed` - `euiFormControlFocusStyle` - `euiFormControlInvalidStyle` - `euiFormControlDisabledTextStyle` - `euiFormControlDisabledStyle` - `euiFormControlReadOnlyStyle` - `euiFormControlText` - `euiFormControlSize` - `euiFormControlGradient` - `euiFormControlLayoutPadding` - `euiFormControlWithIcon` - `euiFormControlIsLoading` - `euiFormControlSideBorderRadius` - `euiPlaceholderPerBrowser` - `euiHiddenSelectableInput` - `euiLink` - `euiLoadingSpinnerBorderColors` - `euiRangeTrackSize` - `euiRangeTrackPerBrowser` - `euiRangeThumbBorder` - `euiRangeThumbBoxShadow` - `euiRangeThumbFocusBoxShadow` - `euiRangeThumbStyle` - `euiRangeThumbPerBrowser` - `euiRangeThumbFocus` - `euiToolTipAnimation` ## [`v96.1.0`](https://github.com/elastic/eui/releases/v96.1.0) **CSS-in-JS conversions** - Removed the following component-specific Sass mixins: ([elastic#8055](elastic/eui#8055)) - `euiButton` - `euiButtonBase` - `euiButtonFocus` - `euiButtonContent` - `euiButtonContentDisabled` - `euiButtonDefaultStyle` - `euiButtonFillStyle` - `euiPanel` - `euiFormControlDefaultShadow` - `euiToolTipTitle` (cherry picked from commit 19e37bf) # Conflicts: # packages/kbn-securitysolution-exception-list-components/src/list_header/__snapshots__/list_header.test.tsx.snap
cee-chen
added a commit
that referenced
this pull request
Oct 4, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Upgrade EUI to v96.1.0 (#194619)](#194619) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cee Chen","email":"549407+cee-chen@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-04T17:53:45Z","message":"Upgrade EUI to v96.1.0 (#194619)\n\n`v95.12.0`⏩`v96.1.0`\r\n\r\n_[Questions? Please see our Kibana upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n## [`v96.0.0`](https://github.com/elastic/eui/releases/v96.0.0)\r\n\r\n- Improved `EuiPageHeader`/`EuiPageTemplate.Header`'s responsive UX:\r\n([#8044](https://github.com/elastic/eui/pull/8044))\r\n- `rightSideItems` are no longer pushed to the side by wide `tabs`\r\ncontent\r\n- `rightSideItems` now wrap more responsively at smaller container\r\nwidths\r\n- Updated `EuiDraggable` with a new `usePortal` prop.\r\n([#8048](https://github.com/elastic/eui/pull/8048))\r\n- This prop portals the dragged element to the body, allowing it to\r\nescape stacking contexts which prevents buggy drag positioning in e.g.\r\npopovers, modals, and flyouts.\r\n\r\n**Bug fixes**\r\n\r\n- Fixed `EuiProvider`'s system color mode detection causing errors\r\nduring server-side rendering\r\n([#8040](https://github.com/elastic/eui/pull/8040))\r\n- Fixed an `EuiDataGrid` rendering bug that was causing bouncing\r\nscrollbar issues ([#8041](https://github.com/elastic/eui/pull/8041))\r\n- Fixed `EuiSearchBox` skips input when running with React 18 in Legacy\r\nMode ([#8047](https://github.com/elastic/eui/pull/8047))\r\n\r\n**Deprecations**\r\n\r\n- Deprecated `EuiPopover`'s `hasDragDrop` prop. Use `EuiDraggable`'s new\r\n`usePortal` prop instead.\r\n([#8048](https://github.com/elastic/eui/pull/8048))\r\n\r\n**Breaking changes**\r\n\r\n- Removed the following exported `.css` files:\r\n([#8045](https://github.com/elastic/eui/pull/8045))\r\n - `@elastic/eui/dist/eui_theme_light.css`\r\n - `@elastic/eui/dist/eui_theme_light.min.css`\r\n - `@elastic/eui/dist/eui_theme_dark.css`\r\n - `@elastic/eui/dist/eui_theme_dark.min.css`\r\n- All EUI components are now on CSS-in-JS. A CSS file/import in\r\nconsuming applications is no longer needed, and is safe to remove.\r\n([#8045](https://github.com/elastic/eui/pull/8045))\r\n- Removed all `src/theme/legacy` Sass exports\r\n([#8054](https://github.com/elastic/eui/pull/8054))\r\n\r\n**CSS-in-JS conversions**\r\n\r\n- Removed the following component-specific Sass variables:\r\n([#8031](https://github.com/elastic/eui/pull/8031))\r\n - `$euiButtonColorDisabled`\r\n - `$euiButtonColorDisabledText`\r\n - `$euiButtonColorGhostDisabled`\r\n - `$euiButtonFontWeight`\r\n - `$euiFormControlIconSizes`\r\n - `$euiFormControlLayoutGroupInputHeight`\r\n - `$euiFormControlLayoutGroupInputCompressedHeight`\r\n - `$euiFormControlLayoutGroupInputCompressedBorderRadius`\r\n - `$euiPageSidebarMinWidth`\r\n - `$euiPageDefaultMaxWidth`\r\n - `$euiPanelPaddingModifiers`\r\n - `$euiPanelBorderRadiusModifiers`\r\n - `$euiPanelBackgroundColorModifiers`\r\n - `$euiRangeTrackColor`\r\n - `$euiRangeHighlightColor`\r\n - `$euiRangeThumbHeight`\r\n - `$euiRangeThumbWidth`\r\n - `$euiRangeThumbBorderColor`\r\n - `$euiRangeThumbBackgroundColor`\r\n - `$euiRangeTrackWidth`\r\n - `$euiRangeTrackHeight`\r\n - `$euiRangeTrackCompressedHeight`\r\n - `$euiRangeTrackBorderWidth`\r\n - `$euiRangeTrackBorderColor`\r\n - `$euiRangeTrackRadius`\r\n - `$euiRangeDisabledOpacity`\r\n - `$euiRangeHighlightHeight`\r\n - `$euiRangeHighlightCompressedHeight`\r\n - `$euiRangeHeight`\r\n - `$euiRangeCompressedHeight`\r\n - `$euiTooltipAnimations`\r\n - `$euiTooltipBackgroundColor`\r\n - `$euiTooltipBorderColor`\r\n- Removed the following Sass mixins due to low external usage:\r\n([#8031](https://github.com/elastic/eui/pull/8031))\r\n - `euiHoverState`\r\n - `euiFocusState`\r\n - `euiDisabledState`\r\n - `euiInteractiveStates`\r\n - `euiFormControlStyle`\r\n - `euiFormControlStyleCompressed`\r\n - `euiFormControlFocusStyle`\r\n - `euiFormControlInvalidStyle`\r\n - `euiFormControlDisabledTextStyle`\r\n - `euiFormControlDisabledStyle`\r\n - `euiFormControlReadOnlyStyle`\r\n - `euiFormControlText`\r\n - `euiFormControlSize`\r\n - `euiFormControlGradient`\r\n - `euiFormControlLayoutPadding`\r\n - `euiFormControlWithIcon`\r\n - `euiFormControlIsLoading`\r\n - `euiFormControlSideBorderRadius`\r\n - `euiPlaceholderPerBrowser`\r\n - `euiHiddenSelectableInput`\r\n - `euiLink`\r\n - `euiLoadingSpinnerBorderColors`\r\n - `euiRangeTrackSize`\r\n - `euiRangeTrackPerBrowser`\r\n - `euiRangeThumbBorder`\r\n - `euiRangeThumbBoxShadow`\r\n - `euiRangeThumbFocusBoxShadow`\r\n - `euiRangeThumbStyle`\r\n - `euiRangeThumbPerBrowser`\r\n - `euiRangeThumbFocus`\r\n - `euiToolTipAnimation`\r\n\r\n## [`v96.1.0`](https://github.com/elastic/eui/releases/v96.1.0)\r\n\r\n**CSS-in-JS conversions**\r\n\r\n- Removed the following component-specific Sass mixins:\r\n([#8055](https://github.com/elastic/eui/pull/8055))\r\n - `euiButton`\r\n - `euiButtonBase`\r\n - `euiButtonFocus`\r\n - `euiButtonContent`\r\n - `euiButtonContentDisabled`\r\n - `euiButtonDefaultStyle`\r\n - `euiButtonFillStyle`\r\n - `euiPanel`\r\n - `euiFormControlDefaultShadow`\r\n - `euiToolTipTitle`","sha":"19e37bf5c52bd0ae3f788ae2b4015c614c901950","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","v9.0.0","v8.16.0","backport:version"],"number":194619,"url":"https://github.com/elastic/kibana/pull/194619","mergeCommit":{"message":"Upgrade EUI to v96.1.0 (#194619)\n\n`v95.12.0`⏩`v96.1.0`\r\n\r\n_[Questions? Please see our Kibana upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n## [`v96.0.0`](https://github.com/elastic/eui/releases/v96.0.0)\r\n\r\n- Improved `EuiPageHeader`/`EuiPageTemplate.Header`'s responsive UX:\r\n([#8044](https://github.com/elastic/eui/pull/8044))\r\n- `rightSideItems` are no longer pushed to the side by wide `tabs`\r\ncontent\r\n- `rightSideItems` now wrap more responsively at smaller container\r\nwidths\r\n- Updated `EuiDraggable` with a new `usePortal` prop.\r\n([#8048](https://github.com/elastic/eui/pull/8048))\r\n- This prop portals the dragged element to the body, allowing it to\r\nescape stacking contexts which prevents buggy drag positioning in e.g.\r\npopovers, modals, and flyouts.\r\n\r\n**Bug fixes**\r\n\r\n- Fixed `EuiProvider`'s system color mode detection causing errors\r\nduring server-side rendering\r\n([#8040](https://github.com/elastic/eui/pull/8040))\r\n- Fixed an `EuiDataGrid` rendering bug that was causing bouncing\r\nscrollbar issues ([#8041](https://github.com/elastic/eui/pull/8041))\r\n- Fixed `EuiSearchBox` skips input when running with React 18 in Legacy\r\nMode ([#8047](https://github.com/elastic/eui/pull/8047))\r\n\r\n**Deprecations**\r\n\r\n- Deprecated `EuiPopover`'s `hasDragDrop` prop. Use `EuiDraggable`'s new\r\n`usePortal` prop instead.\r\n([#8048](https://github.com/elastic/eui/pull/8048))\r\n\r\n**Breaking changes**\r\n\r\n- Removed the following exported `.css` files:\r\n([#8045](https://github.com/elastic/eui/pull/8045))\r\n - `@elastic/eui/dist/eui_theme_light.css`\r\n - `@elastic/eui/dist/eui_theme_light.min.css`\r\n - `@elastic/eui/dist/eui_theme_dark.css`\r\n - `@elastic/eui/dist/eui_theme_dark.min.css`\r\n- All EUI components are now on CSS-in-JS. A CSS file/import in\r\nconsuming applications is no longer needed, and is safe to remove.\r\n([#8045](https://github.com/elastic/eui/pull/8045))\r\n- Removed all `src/theme/legacy` Sass exports\r\n([#8054](https://github.com/elastic/eui/pull/8054))\r\n\r\n**CSS-in-JS conversions**\r\n\r\n- Removed the following component-specific Sass variables:\r\n([#8031](https://github.com/elastic/eui/pull/8031))\r\n - `$euiButtonColorDisabled`\r\n - `$euiButtonColorDisabledText`\r\n - `$euiButtonColorGhostDisabled`\r\n - `$euiButtonFontWeight`\r\n - `$euiFormControlIconSizes`\r\n - `$euiFormControlLayoutGroupInputHeight`\r\n - `$euiFormControlLayoutGroupInputCompressedHeight`\r\n - `$euiFormControlLayoutGroupInputCompressedBorderRadius`\r\n - `$euiPageSidebarMinWidth`\r\n - `$euiPageDefaultMaxWidth`\r\n - `$euiPanelPaddingModifiers`\r\n - `$euiPanelBorderRadiusModifiers`\r\n - `$euiPanelBackgroundColorModifiers`\r\n - `$euiRangeTrackColor`\r\n - `$euiRangeHighlightColor`\r\n - `$euiRangeThumbHeight`\r\n - `$euiRangeThumbWidth`\r\n - `$euiRangeThumbBorderColor`\r\n - `$euiRangeThumbBackgroundColor`\r\n - `$euiRangeTrackWidth`\r\n - `$euiRangeTrackHeight`\r\n - `$euiRangeTrackCompressedHeight`\r\n - `$euiRangeTrackBorderWidth`\r\n - `$euiRangeTrackBorderColor`\r\n - `$euiRangeTrackRadius`\r\n - `$euiRangeDisabledOpacity`\r\n - `$euiRangeHighlightHeight`\r\n - `$euiRangeHighlightCompressedHeight`\r\n - `$euiRangeHeight`\r\n - `$euiRangeCompressedHeight`\r\n - `$euiTooltipAnimations`\r\n - `$euiTooltipBackgroundColor`\r\n - `$euiTooltipBorderColor`\r\n- Removed the following Sass mixins due to low external usage:\r\n([#8031](https://github.com/elastic/eui/pull/8031))\r\n - `euiHoverState`\r\n - `euiFocusState`\r\n - `euiDisabledState`\r\n - `euiInteractiveStates`\r\n - `euiFormControlStyle`\r\n - `euiFormControlStyleCompressed`\r\n - `euiFormControlFocusStyle`\r\n - `euiFormControlInvalidStyle`\r\n - `euiFormControlDisabledTextStyle`\r\n - `euiFormControlDisabledStyle`\r\n - `euiFormControlReadOnlyStyle`\r\n - `euiFormControlText`\r\n - `euiFormControlSize`\r\n - `euiFormControlGradient`\r\n - `euiFormControlLayoutPadding`\r\n - `euiFormControlWithIcon`\r\n - `euiFormControlIsLoading`\r\n - `euiFormControlSideBorderRadius`\r\n - `euiPlaceholderPerBrowser`\r\n - `euiHiddenSelectableInput`\r\n - `euiLink`\r\n - `euiLoadingSpinnerBorderColors`\r\n - `euiRangeTrackSize`\r\n - `euiRangeTrackPerBrowser`\r\n - `euiRangeThumbBorder`\r\n - `euiRangeThumbBoxShadow`\r\n - `euiRangeThumbFocusBoxShadow`\r\n - `euiRangeThumbStyle`\r\n - `euiRangeThumbPerBrowser`\r\n - `euiRangeThumbFocus`\r\n - `euiToolTipAnimation`\r\n\r\n## [`v96.1.0`](https://github.com/elastic/eui/releases/v96.1.0)\r\n\r\n**CSS-in-JS conversions**\r\n\r\n- Removed the following component-specific Sass mixins:\r\n([#8055](https://github.com/elastic/eui/pull/8055))\r\n - `euiButton`\r\n - `euiButtonBase`\r\n - `euiButtonFocus`\r\n - `euiButtonContent`\r\n - `euiButtonContentDisabled`\r\n - `euiButtonDefaultStyle`\r\n - `euiButtonFillStyle`\r\n - `euiPanel`\r\n - `euiFormControlDefaultShadow`\r\n - `euiToolTipTitle`","sha":"19e37bf5c52bd0ae3f788ae2b4015c614c901950"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194619","number":194619,"mergeCommit":{"message":"Upgrade EUI to v96.1.0 (#194619)\n\n`v95.12.0`⏩`v96.1.0`\r\n\r\n_[Questions? Please see our Kibana upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n## [`v96.0.0`](https://github.com/elastic/eui/releases/v96.0.0)\r\n\r\n- Improved `EuiPageHeader`/`EuiPageTemplate.Header`'s responsive UX:\r\n([#8044](https://github.com/elastic/eui/pull/8044))\r\n- `rightSideItems` are no longer pushed to the side by wide `tabs`\r\ncontent\r\n- `rightSideItems` now wrap more responsively at smaller container\r\nwidths\r\n- Updated `EuiDraggable` with a new `usePortal` prop.\r\n([#8048](https://github.com/elastic/eui/pull/8048))\r\n- This prop portals the dragged element to the body, allowing it to\r\nescape stacking contexts which prevents buggy drag positioning in e.g.\r\npopovers, modals, and flyouts.\r\n\r\n**Bug fixes**\r\n\r\n- Fixed `EuiProvider`'s system color mode detection causing errors\r\nduring server-side rendering\r\n([#8040](https://github.com/elastic/eui/pull/8040))\r\n- Fixed an `EuiDataGrid` rendering bug that was causing bouncing\r\nscrollbar issues ([#8041](https://github.com/elastic/eui/pull/8041))\r\n- Fixed `EuiSearchBox` skips input when running with React 18 in Legacy\r\nMode ([#8047](https://github.com/elastic/eui/pull/8047))\r\n\r\n**Deprecations**\r\n\r\n- Deprecated `EuiPopover`'s `hasDragDrop` prop. Use `EuiDraggable`'s new\r\n`usePortal` prop instead.\r\n([#8048](https://github.com/elastic/eui/pull/8048))\r\n\r\n**Breaking changes**\r\n\r\n- Removed the following exported `.css` files:\r\n([#8045](https://github.com/elastic/eui/pull/8045))\r\n - `@elastic/eui/dist/eui_theme_light.css`\r\n - `@elastic/eui/dist/eui_theme_light.min.css`\r\n - `@elastic/eui/dist/eui_theme_dark.css`\r\n - `@elastic/eui/dist/eui_theme_dark.min.css`\r\n- All EUI components are now on CSS-in-JS. A CSS file/import in\r\nconsuming applications is no longer needed, and is safe to remove.\r\n([#8045](https://github.com/elastic/eui/pull/8045))\r\n- Removed all `src/theme/legacy` Sass exports\r\n([#8054](https://github.com/elastic/eui/pull/8054))\r\n\r\n**CSS-in-JS conversions**\r\n\r\n- Removed the following component-specific Sass variables:\r\n([#8031](https://github.com/elastic/eui/pull/8031))\r\n - `$euiButtonColorDisabled`\r\n - `$euiButtonColorDisabledText`\r\n - `$euiButtonColorGhostDisabled`\r\n - `$euiButtonFontWeight`\r\n - `$euiFormControlIconSizes`\r\n - `$euiFormControlLayoutGroupInputHeight`\r\n - `$euiFormControlLayoutGroupInputCompressedHeight`\r\n - `$euiFormControlLayoutGroupInputCompressedBorderRadius`\r\n - `$euiPageSidebarMinWidth`\r\n - `$euiPageDefaultMaxWidth`\r\n - `$euiPanelPaddingModifiers`\r\n - `$euiPanelBorderRadiusModifiers`\r\n - `$euiPanelBackgroundColorModifiers`\r\n - `$euiRangeTrackColor`\r\n - `$euiRangeHighlightColor`\r\n - `$euiRangeThumbHeight`\r\n - `$euiRangeThumbWidth`\r\n - `$euiRangeThumbBorderColor`\r\n - `$euiRangeThumbBackgroundColor`\r\n - `$euiRangeTrackWidth`\r\n - `$euiRangeTrackHeight`\r\n - `$euiRangeTrackCompressedHeight`\r\n - `$euiRangeTrackBorderWidth`\r\n - `$euiRangeTrackBorderColor`\r\n - `$euiRangeTrackRadius`\r\n - `$euiRangeDisabledOpacity`\r\n - `$euiRangeHighlightHeight`\r\n - `$euiRangeHighlightCompressedHeight`\r\n - `$euiRangeHeight`\r\n - `$euiRangeCompressedHeight`\r\n - `$euiTooltipAnimations`\r\n - `$euiTooltipBackgroundColor`\r\n - `$euiTooltipBorderColor`\r\n- Removed the following Sass mixins due to low external usage:\r\n([#8031](https://github.com/elastic/eui/pull/8031))\r\n - `euiHoverState`\r\n - `euiFocusState`\r\n - `euiDisabledState`\r\n - `euiInteractiveStates`\r\n - `euiFormControlStyle`\r\n - `euiFormControlStyleCompressed`\r\n - `euiFormControlFocusStyle`\r\n - `euiFormControlInvalidStyle`\r\n - `euiFormControlDisabledTextStyle`\r\n - `euiFormControlDisabledStyle`\r\n - `euiFormControlReadOnlyStyle`\r\n - `euiFormControlText`\r\n - `euiFormControlSize`\r\n - `euiFormControlGradient`\r\n - `euiFormControlLayoutPadding`\r\n - `euiFormControlWithIcon`\r\n - `euiFormControlIsLoading`\r\n - `euiFormControlSideBorderRadius`\r\n - `euiPlaceholderPerBrowser`\r\n - `euiHiddenSelectableInput`\r\n - `euiLink`\r\n - `euiLoadingSpinnerBorderColors`\r\n - `euiRangeTrackSize`\r\n - `euiRangeTrackPerBrowser`\r\n - `euiRangeThumbBorder`\r\n - `euiRangeThumbBoxShadow`\r\n - `euiRangeThumbFocusBoxShadow`\r\n - `euiRangeThumbStyle`\r\n - `euiRangeThumbPerBrowser`\r\n - `euiRangeThumbFocus`\r\n - `euiToolTipAnimation`\r\n\r\n## [`v96.1.0`](https://github.com/elastic/eui/releases/v96.1.0)\r\n\r\n**CSS-in-JS conversions**\r\n\r\n- Removed the following component-specific Sass mixins:\r\n([#8055](https://github.com/elastic/eui/pull/8055))\r\n - `euiButton`\r\n - `euiButtonBase`\r\n - `euiButtonFocus`\r\n - `euiButtonContent`\r\n - `euiButtonContentDisabled`\r\n - `euiButtonDefaultStyle`\r\n - `euiButtonFillStyle`\r\n - `euiPanel`\r\n - `euiFormControlDefaultShadow`\r\n - `euiToolTipTitle`","sha":"19e37bf5c52bd0ae3f788ae2b4015c614c901950"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
tiansivive
pushed a commit
to tiansivive/kibana
that referenced
this pull request
Oct 7, 2024
`v95.12.0`⏩`v96.1.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v96.0.0`](https://github.com/elastic/eui/releases/v96.0.0) - Improved `EuiPageHeader`/`EuiPageTemplate.Header`'s responsive UX: ([elastic#8044](elastic/eui#8044)) - `rightSideItems` are no longer pushed to the side by wide `tabs` content - `rightSideItems` now wrap more responsively at smaller container widths - Updated `EuiDraggable` with a new `usePortal` prop. ([elastic#8048](elastic/eui#8048)) - This prop portals the dragged element to the body, allowing it to escape stacking contexts which prevents buggy drag positioning in e.g. popovers, modals, and flyouts. **Bug fixes** - Fixed `EuiProvider`'s system color mode detection causing errors during server-side rendering ([elastic#8040](elastic/eui#8040)) - Fixed an `EuiDataGrid` rendering bug that was causing bouncing scrollbar issues ([elastic#8041](elastic/eui#8041)) - Fixed `EuiSearchBox` skips input when running with React 18 in Legacy Mode ([elastic#8047](elastic/eui#8047)) **Deprecations** - Deprecated `EuiPopover`'s `hasDragDrop` prop. Use `EuiDraggable`'s new `usePortal` prop instead. ([elastic#8048](elastic/eui#8048)) **Breaking changes** - Removed the following exported `.css` files: ([elastic#8045](elastic/eui#8045)) - `@elastic/eui/dist/eui_theme_light.css` - `@elastic/eui/dist/eui_theme_light.min.css` - `@elastic/eui/dist/eui_theme_dark.css` - `@elastic/eui/dist/eui_theme_dark.min.css` - All EUI components are now on CSS-in-JS. A CSS file/import in consuming applications is no longer needed, and is safe to remove. ([elastic#8045](elastic/eui#8045)) - Removed all `src/theme/legacy` Sass exports ([elastic#8054](elastic/eui#8054)) **CSS-in-JS conversions** - Removed the following component-specific Sass variables: ([elastic#8031](elastic/eui#8031)) - `$euiButtonColorDisabled` - `$euiButtonColorDisabledText` - `$euiButtonColorGhostDisabled` - `$euiButtonFontWeight` - `$euiFormControlIconSizes` - `$euiFormControlLayoutGroupInputHeight` - `$euiFormControlLayoutGroupInputCompressedHeight` - `$euiFormControlLayoutGroupInputCompressedBorderRadius` - `$euiPageSidebarMinWidth` - `$euiPageDefaultMaxWidth` - `$euiPanelPaddingModifiers` - `$euiPanelBorderRadiusModifiers` - `$euiPanelBackgroundColorModifiers` - `$euiRangeTrackColor` - `$euiRangeHighlightColor` - `$euiRangeThumbHeight` - `$euiRangeThumbWidth` - `$euiRangeThumbBorderColor` - `$euiRangeThumbBackgroundColor` - `$euiRangeTrackWidth` - `$euiRangeTrackHeight` - `$euiRangeTrackCompressedHeight` - `$euiRangeTrackBorderWidth` - `$euiRangeTrackBorderColor` - `$euiRangeTrackRadius` - `$euiRangeDisabledOpacity` - `$euiRangeHighlightHeight` - `$euiRangeHighlightCompressedHeight` - `$euiRangeHeight` - `$euiRangeCompressedHeight` - `$euiTooltipAnimations` - `$euiTooltipBackgroundColor` - `$euiTooltipBorderColor` - Removed the following Sass mixins due to low external usage: ([elastic#8031](elastic/eui#8031)) - `euiHoverState` - `euiFocusState` - `euiDisabledState` - `euiInteractiveStates` - `euiFormControlStyle` - `euiFormControlStyleCompressed` - `euiFormControlFocusStyle` - `euiFormControlInvalidStyle` - `euiFormControlDisabledTextStyle` - `euiFormControlDisabledStyle` - `euiFormControlReadOnlyStyle` - `euiFormControlText` - `euiFormControlSize` - `euiFormControlGradient` - `euiFormControlLayoutPadding` - `euiFormControlWithIcon` - `euiFormControlIsLoading` - `euiFormControlSideBorderRadius` - `euiPlaceholderPerBrowser` - `euiHiddenSelectableInput` - `euiLink` - `euiLoadingSpinnerBorderColors` - `euiRangeTrackSize` - `euiRangeTrackPerBrowser` - `euiRangeThumbBorder` - `euiRangeThumbBoxShadow` - `euiRangeThumbFocusBoxShadow` - `euiRangeThumbStyle` - `euiRangeThumbPerBrowser` - `euiRangeThumbFocus` - `euiToolTipAnimation` ## [`v96.1.0`](https://github.com/elastic/eui/releases/v96.1.0) **CSS-in-JS conversions** - Removed the following component-specific Sass mixins: ([elastic#8055](elastic/eui#8055)) - `euiButton` - `euiButtonBase` - `euiButtonFocus` - `euiButtonContent` - `euiButtonContentDisabled` - `euiButtonDefaultStyle` - `euiButtonFillStyle` - `euiPanel` - `euiFormControlDefaultShadow` - `euiToolTipTitle`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filterManager.add assumes that if it finds a filter that has a query
prop, then it must also have a match clause contained in that query.
User created custom filters may use term queries, range queries and
the like. Once you've added any filters without a match clause like that,
you can no longer add new filters by clicking the "add filter" icon
next to a field in the results. Instead you'll get an error that says
"Cannot read property '' of undefined" when filterManager.add
iterates over your custom filter with no match key.
Fixes: #7246
Related: #8038