From b9f4c66d182a2d1e87aae407f18106bcc103731a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=B8ren=20Louv-Jansen?= Date: Thu, 19 Nov 2020 20:06:25 +0100 Subject: [PATCH 1/2] [Observability] Fix telemetry for Observability Overview --- x-pack/plugins/observability/public/pages/landing/index.tsx | 4 ++-- x-pack/plugins/observability/public/pages/overview/index.tsx | 4 ++-- x-pack/plugins/observability/typings/common.ts | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/x-pack/plugins/observability/public/pages/landing/index.tsx b/x-pack/plugins/observability/public/pages/landing/index.tsx index 7377a1ca0ea52..b5302d5f17f5c 100644 --- a/x-pack/plugins/observability/public/pages/landing/index.tsx +++ b/x-pack/plugins/observability/public/pages/landing/index.tsx @@ -30,8 +30,8 @@ const EuiCardWithoutPadding = styled(EuiCard)` `; export function LandingPage() { - useTrackPageview({ app: 'observability', path: 'landing' }); - useTrackPageview({ app: 'observability', path: 'landing', delay: 15000 }); + useTrackPageview({ app: 'observability-overview', path: 'landing' }); + useTrackPageview({ app: 'observability-overview', path: 'landing', delay: 15000 }); const { core } = usePluginContext(); const theme = useContext(ThemeContext); diff --git a/x-pack/plugins/observability/public/pages/overview/index.tsx b/x-pack/plugins/observability/public/pages/overview/index.tsx index ec00a5b416034..d85bd1a624d7a 100644 --- a/x-pack/plugins/observability/public/pages/overview/index.tsx +++ b/x-pack/plugins/observability/public/pages/overview/index.tsx @@ -56,8 +56,8 @@ export function OverviewPage({ routeParams }: Props) { end: getAbsoluteTime(relativeTime.end, { roundUp: true }) as number, }; - useTrackPageview({ app: 'observability', path: 'overview' }); - useTrackPageview({ app: 'observability', path: 'overview', delay: 15000 }); + useTrackPageview({ app: 'observability-overview', path: 'overview' }); + useTrackPageview({ app: 'observability-overview', path: 'overview', delay: 15000 }); const { data: alerts = [], status: alertStatus } = useFetcher(() => { return getObservabilityAlerts({ core }); diff --git a/x-pack/plugins/observability/typings/common.ts b/x-pack/plugins/observability/typings/common.ts index c86eb924a051e..8093d6077148e 100644 --- a/x-pack/plugins/observability/typings/common.ts +++ b/x-pack/plugins/observability/typings/common.ts @@ -9,7 +9,7 @@ export type ObservabilityApp = | 'infra_logs' | 'apm' | 'uptime' - | 'observability' + | 'observability-overview' | 'stack_monitoring' | 'ux'; From 86df98e7c50f48dae6b4d186eb9e4a6b60157987 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=B8ren=20Louv-Jansen?= Date: Thu, 19 Nov 2020 23:21:55 +0100 Subject: [PATCH 2/2] Fix tsc issue --- .../observability/public/typings/fetch_overview_data/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/observability/public/typings/fetch_overview_data/index.ts b/x-pack/plugins/observability/public/typings/fetch_overview_data/index.ts index a64e6fc55b85a..70c1eb1859ee3 100644 --- a/x-pack/plugins/observability/public/typings/fetch_overview_data/index.ts +++ b/x-pack/plugins/observability/public/typings/fetch_overview_data/index.ts @@ -47,7 +47,7 @@ export type HasData = (params?: HasDataParams) => Promise; export type ObservabilityFetchDataPlugins = Exclude< ObservabilityApp, - 'observability' | 'stack_monitoring' + 'observability-overview' | 'stack_monitoring' >; export interface DataHandler<