[Monitoring][Alerting] Added core features to Kibana services

[igoristic]

Resolves #84483

Accommodates for changes made in #83248

[elasticmachine]

Pinging @elastic/stack-monitoring (Team:Monitoring)

[chrisronline]

@igoristic Nice work detecting this.

I think we should definitely add a test at this point. Something that will fail when other teams make changes that break our usage of alerting.

Maybe we can get away with a unit test that renders our AlertsPanel and makes sure it doesn't error out.

WDYT?

[chrisronline]

If I load up your PR, and comment out https://github.com/elastic/kibana/pull/84486/files#diff-31c6a424a39f837baf2ec267a76691da885bd2ea2ee97199ae09f39714c2cb9bR127 to https://github.com/elastic/kibana/pull/84486/files#diff-31c6a424a39f837baf2ec267a76691da885bd2ea2ee97199ae09f39714c2cb9bR130, the test still passes, but the error still happens in the UI

[igoristic]

@chrisronline

If I load up your PR, and comment out ...

The test was only intended to pass core features to the alert form, so if the alert form requires something else (or new) it would break. But, come to think of it I don't think this test is actually possible as a unit test. Since, we'd still need to mock Legacy shims with core services, via:

jest.mock('../legacy_shims', () => ({
  Legacy: {
    shims: {
      kibanaServices: {
        ...coreMock.createStart(),
      }
    }
  },
}));

Which still makes it bias. Do you have any ideas or suggestions?

[chrisronline]

Is it possible to use mount from enzyme and render our <AlertPanel>, then trigger the popover to show and make sure it loads properly?

Or, we can look into adding a functional test for it?

Also, feel free to make an issue and do this after this too if it will hold up the PR

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: c9f14be

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
monitoring	952.4KB	952.4KB	+4.0B

History

• 💚 Build #91264 succeeded fdff831
• 💚 Build #90649 succeeded bd0f7fa

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[chrisronline]

LGTM! Great work!

[brianseeders]

@igoristic I had to revert this PR because of an incompatibility with something else that was merged. See here for type check failures. Can you fix that up and re-submit?