-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to v30.5.1 #84677
Upgrade EUI to v30.5.1 #84677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to ES UI License Management and ILM snapshots LGTM!
Pinging @elastic/ingest-management (Team:Ingest Management) |
Pinging @elastic/uptime (Team:uptime) |
Pinging @elastic/apm-ui (Team:apm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security solution changes LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KibanaApp changes still LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ML edit LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fleet change 🚀
Pinging @elastic/eui-design (EUI) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💛 Build succeeded, but was flaky
Test FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/smokescreen·ts.lens app lens smokescreen tests should be able to add very long labels and still be able to remove a dimensionStandard Out
Stack Trace
Metrics [docs]Async chunks
Distributable file count
Page load bundle
Unknown metric groups@kbn/ui-shared-deps asset size
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Updated to eui@30.4.1, fixed types and unit tests * Cleanup some imports * Fix a text color swap, now back to danger text * Bump EUI to v30.4.2 * Revert snapshot changes from ownFocus modification * Clean up alert flyout test actions to better represent user actions * Upgrade EUI to 30.5.1 * More accurate test interaction Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
eui@30.2.0
⏩eui@30.5.1
A continuation from #84158
Changes impacting this upgrade:
htmlIdGenerator
utility for jest environmenttextColors
SCSS variable was renamed toeuiTextColors
downCenter
todownLeft
30.5.1
highlight.js
to 9.18.5 (#4313)30.5.0
euiSelectableTemplateSitewideRenderOptions
(#4305)Bug fixes
isPreFiltered
inEuiSelectable
props fixing consumer-side searching (#4305)searchProps.onChange
in anEuiSelectable
(#4292)EuiButtonGroup
when first item in a popover (#4288)EuiComboBox
list (#4301)EuiDatePicker
(#4301)EuiDataGrid
leadingControlColumns (#4269)Theme: Amsterdam
EuiMarkdownEditor
(#4289)30.4.2
Bug fixes
EuiPopover
sownFocus
default fromfalse
totrue
(#4228)30.4.1
useDataGridColumnSelector
,useDataGridColumnSorting
, anduseDataGridStyleSelector
hooks (#4271)Theme: Amsterdam
EuiButton
(#4284)Bug fixes
EuiDataGrid
leadingControlColumns (#4269)30.4.0
eql
glyph inEuiIcon
(#4110)testenv
mock forhtmlIdGenerator
(#4212)Bug fixes
EuiDataGrid
rightmost header cell (#4071)Theme: Amsterdam
outline
and restricting to keyboard navigation (#4242)EuiAvatar
(#4255)30.3.0
EuiColorPaletteDisplay
component (#3865)initialFocusedItemIndex
support toEuiContextMenuPanelDescriptor
(#4223)EuiPopover
sownFocus
prop fromfalse
totrue
(#4228)role="alert"
andaria-live="assertive"
toEuiForm
'sEuiCallOut
for the errors (#4238)menuDown
andmenuUp
glyphs toEuiIcon
(#4244)childrenBetween
inEuiInMemoryTable
(#4248)clickOutsideDisables
totrue
whenownFocus={false}
inEuiFlyout
(#4236)Bug fixes
EuiPopover
bug which prevented the anchor from receiving focus when the popover closes (#4071)EuiInMemoryTable
to avoid mistaken assignment ofsortName
(#4138)EuiImage
's not respecting the optional sizes whenallowFullScreen
is set to true (#4207)EuiDualRange
thumbs when element width is 0 (#4230)EuiSelectable
to callsearchProps.onChange
andsearchProps.onSearch
calls inEuiSelectable
(#4153)EuiComboBox
placeholder
text (#4210)Theme: Amsterdam
line-heights
for withineuiFontSize[size]()
SASS mixins (#4229)