Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] APIs refactoring #85010

Merged
merged 13 commits into from
Dec 5, 2020
Merged

[APM] APIs refactoring #85010

merged 13 commits into from
Dec 5, 2020

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Dec 4, 2020 •
edited
Loading

fixes #84884

sorenlouv
sorenlouv approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for doing this cleanup! 🧹✨

@cauemarcondes cauemarcondes marked this pull request as ready for review December 4, 2020 12:41
@cauemarcondes cauemarcondes requested a review from a team as a code owner December 4, 2020 12:41
@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Dec 4, 2020
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Dec 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.1MB 3.1MB -2.0B

Distributable file count

id before after diff
default 43496 43495 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit d4370ff into elastic:master Dec 5, 2020
@cauemarcondes cauemarcondes deleted the apm-api branch December 5, 2020 10:41
@cauemarcondes cauemarcondes mentioned this pull request Dec 5, 2020
Merged
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Dec 5, 2020
@cauemarcondes
[APM] APIs refactoring (elastic#85010)
f29d2ae 
* renaiming /transaction_groups to /transactions/groups

* renaiming /transaction_groups to /transactions/groups

* renaiming /transaction_groups/charts to /transactions/charts

* renaiming /transaction_groups/distribution to transactions/charts/distribution

* renaiming /transaction_groups/breakdown to transactions/charts/breakdown

* removing /api/apm/transaction_sample. Unused

* renaiming /transaction_groups/error_rate to transactions/charts/error_rate

* removing transaction_groups

* removing /api/apm/transaction_sample. Unused

* renaiming /overview_transaction_groups to transactions/groups/overview

* refactoring error_groups

* addressing pr comments

* fixing test
cauemarcondes added a commit that referenced this pull request Dec 7, 2020
@cauemarcondes
[APM] APIs refactoring (#85010) (#85094)
5cc7057 
* renaiming /transaction_groups to /transactions/groups

* renaiming /transaction_groups to /transactions/groups

* renaiming /transaction_groups/charts to /transactions/charts

* renaiming /transaction_groups/distribution to transactions/charts/distribution

* renaiming /transaction_groups/breakdown to transactions/charts/breakdown

* removing /api/apm/transaction_sample. Unused

* renaiming /transaction_groups/error_rate to transactions/charts/error_rate

* removing transaction_groups

* removing /api/apm/transaction_sample. Unused

* renaiming /overview_transaction_groups to transactions/groups/overview

* refactoring error_groups

* addressing pr comments

* fixing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Delete unused endpoint GET /api/apm/transaction_sample
4 participants
@cauemarcondes @elasticmachine @kibanamachine @sorenlouv