-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TSVB] Fields lists do not populate all the times #85530
Conversation
I have run the flaky test runner 42 times https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1047/ and it doesn't fail but why this |
@stratoula I'm 95% sure the reason for this can be found here #83628. Before we used hardcoded value of 100 buckets but now for auto mode we use 2 props: histogram:maxBars and histogram:barTarget . Default value for last one is |
@elasticmachine merge upstream |
Yes this makes sense 😉 |
Pinging @elastic/kibana-app (Team:KibanaApp) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I have tested it locally and now the fields are populated. Let's keep the functional test skipped (revert these changes) as this suite is unstable and I will take care of all the problems on a second PR
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
* master: (116 commits) Fix UX E2E tests (elastic#85722) Increasing default api key removalDelay to 1h (elastic#85576) align cors settings names with elasticsearch (elastic#85738) unskip tests and make sure submit is not triggered too quickly (elastic#85567) Row trigger 2 (elastic#83167) Add session id to audit log (elastic#85451) [TSVB] Fields lists do not populate all the times (elastic#85530) [Visualize] Removes the external link icon from OSS badges (elastic#85580) fixes EQL tests (elastic#85712) [APM] enable 'log_level' for Go (elastic#85511) ini `1.3.5` -> `1.3.7` (elastic#85707) Fix fleet route protections (elastic#85626) [Monitoring] Some progress on making alerts better in the UI (elastic#81569) [Security Solution] Refactor Timeline Notes to use EuiCommentList (elastic#85256) [Security Solution][Detections][Threshold Rules] Threshold rule exceptions (elastic#85103) [Security Solution] Alerts details (elastic#83963) skip flaky suite (elastic#62060) skip flaky suite (elastic#85098) skip flaky suite (elastic#84020) skip flaky suite (elastic#85671) ...
Closes: #85411
Describe the bug:
There are some occasions that the fields list and the time fields options don't populate.
I have tried to unskip the TSVB functional tests and this test https://github.com/elastic/kibana/blob/master/test/functional/apps/visualize/_tsvb_chart.ts#L133 fails a lot because the options on the list are not loaded.
Steps to reproduce:
This doesn't happen always but it happens a lot. Moreover it is a blocker to unskip the TSVB chart functional tests.
Expected behavior:
Fields should always appear on the list.