Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Convert Logstash-related server files that read from _source to typescript #86787

Merged
merged 4 commits into from
Jan 12, 2021
Merged

[Monitoring] Convert Logstash-related server files that read from _source to typescript #86787

merged 4 commits into from
Jan 12, 2021

Conversation

chrisronline
Copy link
Contributor

Relates to #84370

This PR updates a couple source files used for Logstash monitoring that read from source to using Typescript. This is an attempt to identify all fields read from source to help with #73864

@chrisronline chrisronline added review Team:Monitoring Stack Monitoring team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Dec 22, 2020
@chrisronline chrisronline self-assigned this Dec 22, 2020
@chrisronline chrisronline requested a review from a team December 22, 2020 15:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

igoristic
igoristic approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit fc994df into elastic:master Jan 12, 2021
@chrisronline chrisronline deleted the monitoring/ecs_logstash branch January 12, 2021 16:47
chrisronline added a commit to chrisronline/kibana that referenced this pull request Jan 12, 2021
@chrisronline @kibanamachine
Update logstash files to ts where we read from source (elastic#86787)
2084f2d 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@chrisronline chrisronline mentioned this pull request Jan 12, 2021
Merged
chrisronline added a commit that referenced this pull request Jan 12, 2021
@chrisronline @kibanamachine
Update logstash files to ts where we read from source (#86787) (#88042)
6de6862 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@chrisronline chrisronline mentioned this pull request Jan 18, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igoristic igoristic igoristic approved these changes

Assignees

@chrisronline chrisronline

Labels
release_note:skip Skip the PR/issue when compiling release notes review Team:Monitoring Stack Monitoring team v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisronline @elasticmachine @kibanamachine @igoristic