Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Enable prototype pollution protection in TSVB (#85952) #87087

Merged
merged 1 commit into from
Dec 31, 2020

Conversation

alexwizp
Copy link
Contributor

Backports the following commits to 7.x:

* Enable prototype pollution protection in TSVB

Closes elastic#78908

* Update Dock API Changes

* Replace logging failed in validateObject validation with 400 error

* Move validateObject to kbn-std package and add a description

* Update Doc API Changes

* Rename validateObject function to ensureNoUnsafeProperties

* Rename other validateObject occurrences

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
core 448 449 +1
data 612 613 +1
fleet 457 458 +1
graph 170 171 +1
urlDrilldown 28 29 +1
total +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
data 268.1KB 270.8KB +2.7KB
fleet 964.8KB 967.5KB +2.7KB
graph 1.3MB 1.3MB +2.7KB
triggersActionsUi 1.6MB 1.5MB -26.9KB
total -18.8KB

Distributable file count

id before after diff
default 47609 48371 +762
oss 28009 28008 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 556.9KB 559.6KB +2.7KB
triggersActionsUi 162.5KB 162.6KB +102.0B
urlDrilldown 51.2KB 53.9KB +2.7KB
total +5.5KB
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 31 32 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit 69c4eb2 into elastic:7.x Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants