Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPM] Install Lens assets from packages if present. #88189

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

skh
Copy link
Contributor

@skh skh commented Jan 13, 2021

Summary

Implements #85428

This adds the kibana asset type 'lens' to the supported asset types.

How to test this manually

You need a package that contains a Kibana asset of type lens. I have a modified version of the apache package that can be used with a local registry (ping me on slack), or wait for elastic/integrations#530 to be available in the staging registry The package apache-0.3.1 in the staging registry has one (thanks @mtojek for providing the package!).

Navigate to the package in Fleet->Integration. On the integration detail page, verify that the Lens asset is listed on the right side:

image

Install the package with the "Install Apache assets" on the Settings tab (or any other way). The installation should go through without errors.

After installation, verify in "Visualize" that a Lens asset has been installed and appears in the list of visualizations (for me it's on the third page and called "Workers with Lens", this might be different with the new apache-0.3.1 package from elastic/integrations#530 ):

image

Checklist

@skh skh self-assigned this Jan 13, 2021
@skh skh added Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v7.12.0 v8.0.0 labels Jan 13, 2021
@skh skh force-pushed the 85428-support-lens-asset-type branch from 01061cc to 354b2e1 Compare January 13, 2021 15:29
@skh
Copy link
Contributor Author

skh commented Jan 14, 2021

@elasticmachine merge upstream

@skh skh marked this pull request as ready for review January 14, 2021 12:14
@skh skh requested a review from a team January 14, 2021 12:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Feature:EPM)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@skh skh force-pushed the 85428-support-lens-asset-type branch from 82992f5 to 1c7c7e2 Compare January 14, 2021 14:33
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 970.0KB 970.0KB +27.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 377.0KB 377.0KB +68.0B

History

  • 💚 Build #98812 succeeded 82992f55f8c17654598948e96840273f91da25a3
  • 💔 Build #98788 failed b3a225faa4fe1e98a0c6fd802cc9606cd639ecbc
  • 💚 Build #98583 succeeded 354b2e11f2da71c43cd2a183cdc820325c605a6f
  • 💔 Build #98574 failed 01061cc0947ed4d6aad399c44d9aecf4a0165f54

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works as expected 🚀

@skh skh merged commit d37852a into elastic:master Jan 14, 2021
skh added a commit to skh/kibana that referenced this pull request Jan 14, 2021
* Install Lens assets from packages if present.

* Add integration tests for Lens assets.
skh added a commit that referenced this pull request Jan 14, 2021
* Install Lens assets from packages if present.

* Add integration tests for Lens assets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants