Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incomplete client cert chain when using PKI authentication with the login selector #88229

Merged
merged 3 commits into from
Jan 14, 2021
Merged

Fixes incomplete client cert chain when using PKI authentication with the login selector #88229

merged 3 commits into from
Jan 14, 2021

Commits on Jan 13, 2021

  1. Refactor PKI unit tests 

    Did not change assertions, just refactored in preparation for the
next commit.
    @jportner
    jportner committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    3e451ea View commit details
    Browse the repository at this point in the history

  2. Automatically renegotiate TLS connections during PKI auth 

    When an incomplete client cert chain is detected and the TLS
protocol version supports it (1.0-1.2), renegotiate the connection
to trigger a new TLS handshake and attempt to obtain the full
client cert chain.
    @jportner
    jportner committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    ff190e6 View commit details
    Browse the repository at this point in the history

  3. Change internal socket back to private field

    @jportner
    jportner authored Jan 13, 2021
    Configuration menu
    Copy the full SHA
    044a062 View commit details
    Browse the repository at this point in the history