Patch to histogram to allow zero fill to be turned off in the configuration

[bwmeier]

There's an existing patch to turn off zero-fill in the histogram inside the code, but it is not exposed in the configuration of the histogram panel. This patch adds a configuration option to the editor panel for the histogram to turn that off.

[rashidkpc]

Looks good, have you completed step one of: https://github.com/elasticsearch/kibana/blob/master/CONTRIBUTING.md?

[bobrik]

Doesn't #612 do the same thing? Also, default isn't described, not sure if it's required.

[bwmeier]

@bobrik actually, these are different types of changes - the change in #612 appears to only affect the derivative views. My patch just exposes the zerofill option to the configuration UI. The default remains to zerofill the series, but now a user can control it. :-)

[bwmeier]

@rashidkpc I'm running the agreement by legal, I don't anticipate any issues.

[bobrik]

@bwmeier now I see your point, but #612 affects only non-derivative views just like your patch.

I just wonder what was wrong with #612, I'm not against your change at all.

[bwmeier]

@bobrik - Honestly, I didn't see #612 before I wrote this patch, which I implemented because I needed to show continuous trend graphs for metrics like CPU, memory and task duration. It looks like we just took different approaches: #612 is ignoring the zerofill option in the histogram panel and creating its own gapfill option, and I was just using the zerofill option as is and exposing it to the editor.

Essentially, both patches are expressing the need to be able to select between the four possible fill_style values: all, no, minimal, null (IMHO, these are not very descriptive of the actual style, but that's neither here nor there). I'll leave it up to @rashidkpc and team which way they want to implement that...

[bobrik]

@bwmeier there was no zerofill property at the time of #612 :)

[bwmeier]

@bobrik - makes sense. I'm not sure which is better overall, and honestly, I don't really care, as long as the functionality gets reflected one way or another - I just need smooth trendlines :-)

[bwmeier]

Legal is still reviewing the agreement, should be approved soon.

[gregberge]

+1 👍 for this issue !

[carguel]

+1

[Chadwiki]

+1

[rashidkpc]

Since this appears to have stalled, I'm going to close it and see about merging #888