Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Fix Monitor status toggle alert receovery state #89273

Merged
merged 22 commits into from
Apr 29, 2021
Merged

[Uptime] Fix Monitor status toggle alert receovery state #89273

merged 22 commits into from
Apr 29, 2021

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Jan 26, 2021 •
edited
Loading

Summary

Fixes: elastic/uptime#289

For uptime monitor list status alert, this pr fixes the recovery part.

Testing

  • Enable an alert on a monitor using monitor list status alert toggle
  • When monitor is down it should send an alert to the connector
  • When monitor is up, it should send that monitor is up message

image

@shahzad31 shahzad31 changed the title wip [Uptime] Monitor status toggle alert resolve state Feb 15, 2021
@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@shahzad31 shahzad31 changed the title [Uptime] Monitor status toggle alert resolve state [Uptime] Fix Monitor status toggle alert receovery state Apr 27, 2021
@shahzad31 shahzad31 marked this pull request as ready for review April 27, 2021 11:57
@shahzad31 shahzad31 requested a review from a team as a code owner April 27, 2021 11:57
@shahzad31 shahzad31 self-assigned this Apr 27, 2021
@shahzad31 shahzad31 added v7.14.0 v8.0.0 release_note:fix Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Apr 27, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 1.2MB 1.2MB +2.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

dominiqueclarke
dominiqueclarke approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested with

  • Server log
  • Pager duty
  • Slack
  • index
  • webhooks
  • teams

@shahzad31 shahzad31 merged commit 18213b6 into elastic:master Apr 29, 2021
@shahzad31 shahzad31 deleted the monitor-status-alert-resolve branch April 29, 2021 16:42
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 3, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 89273 or prevent reminders by adding the backport:skip label.

@dominiqueclarke dominiqueclarke added the auto-backport Deprecated - use backport:version if exact versions are needed label May 3, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request May 3, 2021
@shahzad31 @kibanamachine
[Uptime] Fix Monitor status toggle alert receovery state (elastic#89273)
ad65ec8 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request May 3, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request May 3, 2021
@shahzad31 @kibanamachine
[Uptime] Fix Monitor status toggle alert receovery state (elastic#89273)
7b61c38 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request May 3, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.13
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 3, 2021
@kibanamachine @shahzad31
[Uptime] Fix Monitor status toggle alert receovery state (#89273) (#9…
c40f965 
…9094)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
kibanamachine added a commit that referenced this pull request May 3, 2021
@kibanamachine @shahzad31
[Uptime] Fix Monitor status toggle alert receovery state (#89273) (#9…
2edc170 
…9095)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees

@shahzad31 shahzad31

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.13.0 v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uptime monitor status toggle alert should implement recovery action
4 participants
@shahzad31 @elasticmachine @kibanamachine @dominiqueclarke