-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[coverage] fix jest merging #90915
[coverage] fix jest merging #90915
Changes from all commits
64d698d
bfb433c
93b3a6f
d45324a
c51b2d7
0831501
9a252f4
ce22bdc
26d80be
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
#!/bin/bash | ||
|
||
EXTRACT_START_DIR=tmp/extracted_coverage | ||
EXTRACT_END_DIR=target/kibana-coverage | ||
COMBINED_EXRACT_DIR=/${EXTRACT_START_DIR}/${EXTRACT_END_DIR} | ||
|
||
|
||
echo "### Copy combined jest report" | ||
mkdir -p $EXTRACT_END_DIR/jest-combined | ||
cp -r $COMBINED_EXRACT_DIR/jest-combined/. $EXTRACT_END_DIR/jest-combined/ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"id": "coverage-fixtures", | ||
"id": "coverageFixtures", | ||
"version": "kibana", | ||
"server": false, | ||
"ui": true | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,4 +32,7 @@ else | |
|
||
echo " -> Running jest integration tests with coverage" | ||
node scripts/jest_integration --ci --verbose --coverage || true; | ||
|
||
echo " -> Combine code coverage in a single report" | ||
yarn nyc report --nycrc-path src/dev/code_coverage/nyc_config/nyc.jest.config.js | ||
Comment on lines
+35
to
+37
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since we run jest tests in a single place now, I added report generation right after tests are done. |
||
fi |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -148,9 +148,10 @@ def generateReports(title) { | |
cd .. | ||
. src/dev/code_coverage/shell_scripts/extract_archives.sh | ||
. src/dev/code_coverage/shell_scripts/fix_html_reports_parallel.sh | ||
. src/dev/code_coverage/shell_scripts/merge_jest_and_functional.sh | ||
# zip combined reports | ||
tar -czf kibana-coverage.tar.gz target/kibana-coverage/**/* | ||
. src/dev/code_coverage/shell_scripts/merge_functional.sh | ||
. src/dev/code_coverage/shell_scripts/copy_jest_report.sh | ||
# zip functional combined report | ||
tar -czf kibana-functional-coverage.tar.gz target/kibana-coverage/functional-combined/* | ||
Comment on lines
-151
to
+154
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We only merge functional tests now, but we still need to copy jest for ingestion. Functional combined report is uploaded separately since jest was already in artefacts after tests execution. |
||
""", title) | ||
} | ||
|
||
|
@@ -162,7 +163,7 @@ def uploadCombinedReports() { | |
|
||
kibanaPipeline.uploadGcsArtifact( | ||
"kibana-ci-artifacts/jobs/${env.JOB_NAME}/${BUILD_NUMBER}/coverage/combined", | ||
'kibana-coverage.tar.gz' | ||
'kibana-functional-coverage.tar.gz' | ||
) | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -188,7 +188,7 @@ def withGcsArtifactUpload(workerName, closure) { | |
def ARTIFACT_PATTERNS = [ | ||
'target/junit/**/*', | ||
'target/kibana-*', | ||
'target/kibana-coverage/**/*', | ||
'target/kibana-coverage/jest/**/*', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should not upload |
||
'target/kibana-security-solution/**/*.png', | ||
'target/test-metrics/*', | ||
'target/test-suites-ci-plan.json', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After merging master on Monday I faced this error in functional tests:
I changed plugin id according error an looks like it is working fine