Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Add linux and mac diagnostics switches to advanced Policy #95819

Merged
merged 2 commits into from
Mar 30, 2021
Merged

[Security Solution] Add linux and mac diagnostics switches to advanced Policy #95819

merged 2 commits into from
Mar 30, 2021

Conversation

kevinlog
Copy link
Contributor

@kevinlog kevinlog commented Mar 30, 2021 •
edited
Loading

Summary

Adds diagnostic controls to Advanced Policy for Linux and Mac

image

Saved Policy:
image

Checklist

Delete any items that are not applicable to this PR.

@kevinlog kevinlog added Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.12.1 labels Mar 30, 2021
@kevinlog kevinlog requested a review from a team as a code owner March 30, 2021 16:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@kevinlog
Copy link
Contributor Author

@elasticmachine merge upstream

paul-tavares
paul-tavares approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one question, but other than that it LGTM

...ck/plugins/security_solution/public/management/pages/policy/models/advanced_policy_schema.ts Show resolved Hide resolved
ferullo
ferullo approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@ferullo ferullo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Sorry this didn't get communicated to you all for 7.12.0.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.2MB 7.2MB +640.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kevinlog kevinlog merged commit 9c21f41 into elastic:master Mar 30, 2021
@kevinlog kevinlog deleted the task/add-diagnostics-for-OSs branch March 30, 2021 18:52
This was referenced Mar 30, 2021
Merged
Merged
kevinlog added a commit to kevinlog/kibana that referenced this pull request Mar 30, 2021
@kevinlog @kibanamachine
add linux and mac diagnostics switches (elastic#95819)
f2e0920 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kevinlog added a commit that referenced this pull request Mar 30, 2021
@kevinlog @kibanamachine
add linux and mac diagnostics switches (#95819) (#95834)
25a0a12 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kevinlog added a commit that referenced this pull request Mar 30, 2021
@kevinlog @kibanamachine
add linux and mac diagnostics switches (#95819) (#95833)
85feb5f 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-tavares paul-tavares paul-tavares approved these changes

@ferullo ferullo ferullo approved these changes

Assignees
No one assigned
Labels
release_note:fix Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.12.1 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kevinlog @elasticmachine @kibanamachine @ferullo @paul-tavares