Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce security plugin page load bundle #98819

Merged
merged 5 commits into from
Apr 30, 2021
Merged

Reduce security plugin page load bundle #98819

merged 5 commits into from
Apr 30, 2021

Conversation

legrego
Copy link
Member

@legrego legrego commented Apr 29, 2021 •
edited
Loading

Summary

Reduces the page load bundle for the security plugin by making select imports async.

image

Resolves #95869

@legrego legrego added release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.14.0 v8.0.0 labels Apr 30, 2021
@legrego legrego marked this pull request as ready for review April 30, 2021 12:58
@legrego legrego requested review from a team as code owners April 30, 2021 12:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

legrego
legrego commented Apr 30, 2021
View reviewed changes
packages/kbn-optimizer/limits.yml
securityOss: 30806
securitySolution: 187863
share: 99061
snapshotRestore: 79032
spaces: 387915
spaces: 57868
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly required for this PR, but we did the work to drop the spaces bundle already, so we should make sure it stays that way

jportner
jportner approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, LGTM! 🎉

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
security 748.6KB 764.3KB +15.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
security 125.1KB 79.0KB -46.1KB
Unknown metric groups

async chunk count

id before after diff
security 17 21 +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 30, 2021
@legrego legrego merged commit a5e8056 into elastic:master Apr 30, 2021
@legrego legrego deleted the security/page-load-bundle-1 branch April 30, 2021 15:19
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 98819

legrego added a commit to legrego/kibana that referenced this pull request Apr 30, 2021
@legrego
Reduce security plugin page load bundle (elastic#98819)
e7a94bb 
# Conflicts:
#	packages/kbn-optimizer/limits.yml
@legrego legrego mentioned this pull request Apr 30, 2021
Merged
legrego added a commit that referenced this pull request Apr 30, 2021
@legrego @kibanamachine
Reduce security plugin page load bundle (#98819) (#98950)
5d2f929 
# Conflicts:
#	packages/kbn-optimizer/limits.yml

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jportner jportner jportner approved these changes

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[security] Reduce page load bundle to under 100kB
5 participants
@legrego @elasticmachine @kibanamachine @jbudz @jportner