Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix plugin installation script #13289

Merged
merged 1 commit into from
Oct 7, 2021
Merged

fix plugin installation script #13289

merged 1 commit into from
Oct 7, 2021

Conversation

kaisecheng
Copy link
Contributor

@kaisecheng kaisecheng commented Oct 7, 2021 •
edited
Loading

Release notes

[rn:skip]

What does this PR do?

Fix the logstash-plugin install script that fails to install plugin

Why is it important/What is the impact to the user?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Closes #13281

Use cases

Screenshots

Logs

@kaisecheng kaisecheng changed the title fix plugin installation script [WIP] fix plugin installation script Oct 7, 2021
@kaisecheng kaisecheng changed the title [WIP] fix plugin installation script fix plugin installation script Oct 7, 2021
jsvd
jsvd approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please mention somewhere in the commit message that this is needed for a call to to_set in expand_logstash_mixin_dependencies

@kaisecheng kaisecheng merged commit aa6afa5 into elastic:master Oct 7, 2021
kaisecheng added a commit to kaisecheng/logstash that referenced this pull request Oct 7, 2021
@kaisecheng
fix plugin installation script (elastic#13289)
a9547c8 
This commit requires `set`, as bundler #expand_logstash_mixin_dependencies call `to_set`
@kaisecheng kaisecheng mentioned this pull request Oct 7, 2021
Merged
kaisecheng added a commit to kaisecheng/logstash that referenced this pull request Oct 7, 2021
@kaisecheng
fix plugin installation script (elastic#13289)
adb5fc5 
This commit requires `set`, as bundler #expand_logstash_mixin_dependencies call `to_set`
@kaisecheng kaisecheng mentioned this pull request Oct 7, 2021
Merged
kaisecheng added a commit that referenced this pull request Oct 7, 2021
@kaisecheng
fix plugin installation script (#13289) (#13291)
a017de9 
This commit requires `set`, as bundler #expand_logstash_mixin_dependencies call `to_set`
Fixed: #13281
kaisecheng added a commit that referenced this pull request Oct 7, 2021
@kaisecheng
fix plugin installation script (#13289) (#13290)
f59bd17 
This commit requires `set`, as bundler #expand_logstash_mixin_dependencies call `to_set`
Fixed: #13281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsvd jsvd jsvd approved these changes

Assignees
No one assigned
Labels
v7.15.1 v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fail to pass CI integration test secret_store_spec
3 participants
@kaisecheng @jsvd @roaksoax