Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset criticality file upload #5112

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Asset criticality file upload #5112

merged 2 commits into from
Apr 25, 2024

Conversation

natasha-moore-elastic
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic commented Apr 23, 2024 •
edited
Loading

@natasha-moore-elastic natasha-moore-elastic added Feature: Entity Analytics Features or enhancements for any of the Entity pages Priority: Medium Issues that have relevance, but aren't urgent Effort: Medium Issues that take moderate but not substantial time to complete Docset: ESS Issues that apply to docs in the Stack release Team: Entity Analytics v8.14.0 labels Apr 23, 2024
@natasha-moore-elastic natasha-moore-elastic self-assigned this Apr 23, 2024
@github-actions GitHub Actions
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@natasha-moore-elastic natasha-moore-elastic marked this pull request as ready for review April 23, 2024 15:40
@natasha-moore-elastic natasha-moore-elastic requested a review from a team as a code owner April 23, 2024 15:40
benironside
benironside approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a couple minor suggestions

docs/advanced-entity-analytics/asset-criticality.asciidoc Show resolved Hide resolved
docs/advanced-entity-analytics/asset-criticality.asciidoc Show resolved Hide resolved
@natasha-moore-elastic natasha-moore-elastic merged commit 9f11b59 into main Apr 25, 2024
3 checks passed
@natasha-moore-elastic natasha-moore-elastic deleted the issue-5085-file-upload branch April 25, 2024 11:08
mergify bot pushed a commit that referenced this pull request Apr 25, 2024
@natasha-moore-elastic @mergify
Asset criticality file upload (#5112)
7e77307 
(cherry picked from commit 9f11b59)
@mergify mergify bot mentioned this pull request Apr 25, 2024
Merged
natasha-moore-elastic added a commit that referenced this pull request Apr 25, 2024
@mergify @natasha-moore-elastic
Asset criticality file upload (#5112) (#5129)
7e60170 
(cherry picked from commit 9f11b59)

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
@natasha-moore-elastic natasha-moore-elastic mentioned this pull request May 16, 2024
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benironside benironside benironside approved these changes

Assignees

@natasha-moore-elastic natasha-moore-elastic

Labels
Docset: ESS Issues that apply to docs in the Stack release Effort: Medium Issues that take moderate but not substantial time to complete Feature: Entity Analytics Features or enhancements for any of the Entity pages Priority: Medium Issues that have relevance, but aren't urgent Team: Entity Analytics v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natasha-moore-elastic @benironside