Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request][Detection Engine][ESS][8.14] GA-ing alert suppression for custom query rule #5114

Merged
merged 9 commits into from
Apr 30, 2024

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Apr 23, 2024

NOTE TO SELF: #5057 needs to be merged before I can merge this PR

Contributes to #5104

Previews:

Twin Serverless PR: https://github.com/elastic/staging-serverless-security-docs/pull/330

@nastasha-solomon nastasha-solomon added Feature: Rules Team: Detection Engine Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Small Issues that can be resolved quickly v8.14.0 labels Apr 23, 2024
@nastasha-solomon nastasha-solomon self-assigned this Apr 23, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

nastasha-solomon and others added 3 commits April 23, 2024 23:59
Suppression page has the updated tech preview label lang. No need to change it elsewhere.
@nastasha-solomon nastasha-solomon marked this pull request as ready for review April 25, 2024 19:13
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner April 25, 2024 19:13
vitaliidm
vitaliidm previously approved these changes Apr 26, 2024
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a li'l syntax fix

docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
@nastasha-solomon nastasha-solomon merged commit 0d835e1 into main Apr 30, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Apr 30, 2024
…ustom query rule (#5114)

* Updates tech preview text

* Removing tag from custom query rule

* Reverting change to lang

Suppression page has the updated tech preview label lang. No need to change it elsewhere.

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit 0d835e1)
@nastasha-solomon nastasha-solomon deleted the issue-5104-cqr-alert-suppress-ga branch April 30, 2024 14:50
nastasha-solomon added a commit that referenced this pull request Apr 30, 2024
…n for custom query rule (backport #5114) (#5143)

* Updates tech preview text

* Removing tag from custom query rule

* Reverting change to lang

Suppression page has the updated tech preview label lang. No need to change it elsewhere.

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit 0d835e1)

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
@nastasha-solomon nastasha-solomon mentioned this pull request May 16, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: Small Issues that can be resolved quickly Feature: Rules Priority: High Issues that are time-sensitive and/or are of high customer importance Team: Detection Engine v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants