Issue #518: Remove beta tag from detections #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No major changes made. Added a line under line 6 so could commit a change and create a pull request.
nastasha-solomon
added
Team: Detections/Response
jmikell821
reviewed
Feb 18, 2021
| @@ -5,6 +5,7 @@ | |||
|
|
|||
| beta[] | |||
There was a problem hiding this comment.
Hey guys @nastasha-solomon and @Donnater the other merged PR #519 had the beta[] tag removed. Please make sure we do that here. #519 was not yet backported -- don't know if that was intentional or not, but when this is merged please backport to 7.12, 7.x, 7.11. Will be good practice for Nastasha. Thanks!
There was a problem hiding this comment.
@jmikell821: That PR was actually closed, not merged. We'll likely merge this one instead.
nastasha-solomon
added a commit
to nastasha-solomon/security-docs
that referenced
this pull request
Feb 22, 2021
No major changes made. Added a line under line 6 so could commit a change and create a pull request.
nastasha-solomon
added a commit
to nastasha-solomon/security-docs
that referenced
this pull request
Feb 22, 2021
No major changes made. Added a line under line 6 so could commit a change and create a pull request.
nastasha-solomon
added a commit
to nastasha-solomon/security-docs
that referenced
this pull request
Feb 22, 2021
No major changes made. Added a line under line 6 so could commit a change and create a pull request.
nastasha-solomon
added a commit
that referenced
this pull request
Feb 22, 2021
nastasha-solomon
added a commit
that referenced
this pull request
Feb 22, 2021
nastasha-solomon
added a commit
that referenced
this pull request
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #518. No major changes made. Added a line under line 6 so could commit a change and create a pull request.