From 329ca96bb820c306f4fd01252d568c4923ed48c4 Mon Sep 17 00:00:00 2001 From: George Rawlinson Date: Wed, 8 Jan 2025 09:27:51 +1300 Subject: [PATCH] fix(cmake): remove invalid keywords (DEPENDS) Added in CMake 3.31, [CMP0175][0] explicitly states that specific keywords are invalid. In this case, it is fine to remove DEPENDS since both DEPENDS and TARGET share the same argument (${FIRMWARE_NAME}). [0]: https://cmake.org/cmake/help/latest/policy/CMP0175.html --- cmake/DaisyProject.cmake | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cmake/DaisyProject.cmake b/cmake/DaisyProject.cmake index 17ea6c9da..1fa234a8a 100644 --- a/cmake/DaisyProject.cmake +++ b/cmake/DaisyProject.cmake @@ -97,10 +97,10 @@ target_link_options(${FIRMWARE_NAME} PUBLIC $<$:LINKER:--print-memory-usage> ) -add_custom_command(TARGET ${FIRMWARE_NAME} POST_BUILD +add_custom_command(TARGET ${FIRMWARE_NAME} + POST_BUILD COMMAND ${CMAKE_OBJCOPY} -O ihex -S $ $/${FIRMWARE_NAME}.hex BYPRODUCTS ${FIRMWARE_NAME}.hex - DEPENDS ${FIRMWARE_NAME} COMMENT "Generating HEX image" VERBATIM ) @@ -108,10 +108,10 @@ add_custom_command(TARGET ${FIRMWARE_NAME} POST_BUILD option(DAISY_GENERATE_BIN "Sets whether or not to generate a raw binary image using objcopy (warning this is a very large file, as it is a representation of the *full memory space*.)") if(DAISY_GENERATE_BIN) - add_custom_command(TARGET ${FIRMWARE_NAME} POST_BUILD + add_custom_command(TARGET ${FIRMWARE_NAME} + POST_BUILD COMMAND ${CMAKE_OBJCOPY} -O binary -S $ $/${FIRMWARE_NAME}.bin BYPRODUCTS ${FIRMWARE_NAME}.bin - DEPENDS ${FIRMWARE_NAME} COMMENT "Generating binary image" VERBATIM )