diff --git a/.changeset/thin-bags-tap.md b/.changeset/thin-bags-tap.md index 2d9285e64db..bdfddb28ac5 100644 --- a/.changeset/thin-bags-tap.md +++ b/.changeset/thin-bags-tap.md @@ -2,4 +2,4 @@ "app-builder-lib": major --- -Add skipVerification flag in Mac's notarize options +Remove spctl check from Mac notarization step diff --git a/packages/app-builder-lib/scheme.json b/packages/app-builder-lib/scheme.json index 9f2807c2361..6ce77956850 100644 --- a/packages/app-builder-lib/scheme.json +++ b/packages/app-builder-lib/scheme.json @@ -3716,13 +3716,6 @@ "string" ] }, - "skipVerification": { - "description": "Skip spctl verification when notarizing. Needed in some edge-cases when running electron-builder in CI", - "type": [ - "null", - "boolean" - ] - }, "teamId": { "description": "The team ID you want to notarize under. Only needed if using `notarytool`", "type": [ diff --git a/packages/app-builder-lib/src/macPackager.ts b/packages/app-builder-lib/src/macPackager.ts index f4235427d70..bd02eb98608 100644 --- a/packages/app-builder-lib/src/macPackager.ts +++ b/packages/app-builder-lib/src/macPackager.ts @@ -1,5 +1,5 @@ import BluebirdPromise from "bluebird-lst" -import { deepAssign, Arch, AsyncTaskManager, exec, InvalidConfigurationError, log, use, getArchSuffix, spawn } from "builder-util" +import { deepAssign, Arch, AsyncTaskManager, exec, InvalidConfigurationError, log, use, getArchSuffix } from "builder-util" import { signAsync } from "@electron/osx-sign" import { SignOptions } from "@electron/osx-sign/dist/cjs/types" import { mkdir, readdir } from "fs/promises" @@ -488,12 +488,6 @@ export default class MacPackager extends PlatformPackager { } const options = this.generateOptions(appPath, appleId, appleIdPassword) await notarize(options) - // Verify - if (typeof notarizeOptions === "object" && notarizeOptions?.skipVerification) { - log.info({ reason: "`skipVerification` is explicitly set to true" }, "skipped spctl verification") - } else { - await spawn("spctl", ["-a", "-t", "open", "--context", "context:primary-signature", "-v", `"${appPath}"`]) - } log.info(null, "notarization successful") } diff --git a/packages/app-builder-lib/src/options/macOptions.ts b/packages/app-builder-lib/src/options/macOptions.ts index 33dec8780a2..c41ed4c8456 100644 --- a/packages/app-builder-lib/src/options/macOptions.ts +++ b/packages/app-builder-lib/src/options/macOptions.ts @@ -230,11 +230,6 @@ export interface NotarizeOptions { * The team ID you want to notarize under. Only needed if using `notarytool` */ readonly teamId?: string | null - - /** - * Skip spctl verification when notarizing. Needed in some edge-cases when running electron-builder in CI - */ - readonly skipVerification?: boolean | null } export interface DmgOptions extends TargetSpecificOptions {