fix: close file stream when error #7094
Conversation
🦋 Changeset detectedLatest commit: f593aba The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| options.callback(error) | ||
| } | ||
| fileOut.close() | ||
| options.callback(error) |
There was a problem hiding this comment.
Great callout on closing the stream
I think we still need this though:
if (!options.options.cancellationToken.cancelled) {
options.callback(error)
}
There was a problem hiding this comment.
Great callout on closing the stream
I think we still need this though:
if (!options.options.cancellationToken.cancelled) { options.callback(error) }
callback should be invoked even if the downloading is cancelled by user.
There was a problem hiding this comment.
Hmm, I disagree though, as user cancelation is an explicit action that I think should not resolve into an error event.
file stream should be closed when error.