Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling a DLL results in a error when attempting to load the vendor file in dev #359

Closed
ghost opened this issue Apr 12, 2020 · 4 comments · Fixed by #366
Closed

Compiling a DLL results in a error when attempting to load the vendor file in dev #359

ghost opened this issue Apr 12, 2020 · 4 comments · Fixed by #366

Comments

@ghost
Copy link

ghost commented Apr 12, 2020

  • Versions:

    • electron-builder: 22.4.1
    • electron-webpack: 2.8.2
  • Target: Windows, dev with a vendor DLL

After creating a simple Electron app that uses React/React DOM and puts both in a vendor file, I cannot start the project in dev mode.

image

I believe this is related to the changes done to address #357 which has caused Webpack, or at least html-loader to try to require the vendor file instead of fetching it from the dev server.

One possible fix would be to set attributes=false in the html-loader call inside the renderer target configurator. Alternatively, it may be possible to disable just the processing of src attributes on script tags. See https://webpack.js.org/loaders/html-loader/#attributes for more details on that.

@ninescore
Copy link

I also encountered the same problem, how can I quickly solve it?

@ghost
Copy link
Author

ghost commented Jul 29, 2020

I also encountered the same problem, how can I quickly solve it?

I'd recommend taking a look at the open PR #366. It provides a solution. This can be applied locally by modifying your node_modules but a permanent fix is pending on that PR being merged.

@ninescore
Copy link

I also encountered the same problem, how can I quickly solve it?

I'd recommend taking a look at the open PR #366. It provides a solution. This can be applied locally by modifying your node_modules but a permanent fix is pending on that PR being merged.

Temporarily resolved, thank you very much, and hope to release the revised version as soon as possible

@ghost
Copy link
Author

ghost commented Dec 1, 2020

Is there going to be any movement on this, @develar, or should I investigate alternative solutions to using Webpack with Electron?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant