Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic instead of hard-coded dev main entry #367

Closed
alfrededison opened this issue Apr 27, 2020 · 0 comments
Closed

Dynamic instead of hard-coded dev main entry #367

alfrededison opened this issue Apr 27, 2020 · 0 comments

Comments

@alfrededison
Copy link

  • Version: ^2.8.2
  • Target:

Currently, out/dev/dev-runner.js use hard-coded path to main entry to start electron in dev

args.push(path.join(projectDir, "dist/main/main.js"));

We should use dynamic path instead, like

args.push(path.join(electronWebpackConfig.commonDistDirectory, "main", "main.js"));
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alfrededison