fix: resolve custom commonSourceDir before setting up watch plugin

[stristr]

This fixes at least one of the issues in #84 that was affecting my project—the WatchFilterPlugin is set up to rely on absolute paths in order to behave as expected, and this breaks HMR when commonSourceDirectory is specified at all.

Note: I have a setup that looks like this (common when using Lerna/Yarn workspaces in a monorepo):

project/
└── packages
    ├── common-lib-1
    ├── common-lib-2
    ├── electron-app-1
    └── electron-app-2

In this case, I actually want my commonSourceDirectory to be ".." (I'm running electron-webpack out of e.g. project/packages/electron-app1), which fully breaks HMR. I considered adding a new config option like watchDirectories: string[] and changing the logic to not overload the meaning of commonSourceDirectory, but I think this is clean enough for all the use cases I can think of. @develar, please LMK if you prefer something else!

[develar]

Thanks for digging it! Hmm... the question is why here we have not resolved path. I think, our config resolver should resolve it, so, we can be sure that the same correct path is used in all functionality.

[stristr]

Ah, okay. I think this is because configurator.commonSourceDirectory is the pre-resolved thing we actually want to use if the option is provided at all. I updated and force pushed to do that instead 😄

[stristr]

Sorry if my last comment was unclear, @develar! This PR has been updated to reflect a change which is still necessary in order for HMR to work when configurator.commonSourceDirectory is set to a relative path. So it still should be reviewed/merged.

The problem is that the filter plugin is using configurator.electronWebpackConfiguration.commonSourceDirectory instead of configurator.commonSourceDirectory, which is the pre-resolved path we want.

[develar]

@stristr PR merged with some my changes :) See ae2a2f1 and release https://github.com/electron-userland/electron-webpack/releases/tag/v2.6.1

[stristr]

Nice—this release works in my project!

Thank you very much for the quick release.