From ce7afed12a0d1fe0600457129ff5d501ec48332a Mon Sep 17 00:00:00 2001 From: Jim O'Brien Date: Fri, 7 Aug 2020 17:09:17 +0100 Subject: [PATCH 1/2] feat: disable hard-coded sourcemap support via environment variable In reference to [#285][1], this allows users to disable the hard-coded insertion of a script tag that is inserted into the generated root HTML page, by passing an environment variable, `ELECTRON_WEBPACK_DISABLE_SOURCE_MAP_SUPPORT`. [1]: https://github.com/electron-userland/electron-webpack/issues/285 --- packages/electron-webpack/src/targets/RendererTarget.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/electron-webpack/src/targets/RendererTarget.ts b/packages/electron-webpack/src/targets/RendererTarget.ts index e462bfa..8818857 100644 --- a/packages/electron-webpack/src/targets/RendererTarget.ts +++ b/packages/electron-webpack/src/targets/RendererTarget.ts @@ -203,7 +203,9 @@ async function generateIndexFile(configurator: WebpackConfigurator, nodeModulePa html = html.replace("", ``) } - html = html.replace("", '') + if (process.env.ELECTRON_WEBPACK_DISABLE_SOURCE_MAP_SUPPORT) { + html = html.replace("", ''); + } if (scripts.length) { html = html.replace("", `${scripts.join("")}`) From f84f5aac0b759187cd7df9c3002a45e30e9e238b Mon Sep 17 00:00:00 2001 From: Jim O'Brien Date: Wed, 12 Aug 2020 10:05:32 +0100 Subject: [PATCH 2/2] Update packages/electron-webpack/src/targets/RendererTarget.ts --- packages/electron-webpack/src/targets/RendererTarget.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/electron-webpack/src/targets/RendererTarget.ts b/packages/electron-webpack/src/targets/RendererTarget.ts index 8818857..f9c58d2 100644 --- a/packages/electron-webpack/src/targets/RendererTarget.ts +++ b/packages/electron-webpack/src/targets/RendererTarget.ts @@ -203,7 +203,7 @@ async function generateIndexFile(configurator: WebpackConfigurator, nodeModulePa html = html.replace("", ``) } - if (process.env.ELECTRON_WEBPACK_DISABLE_SOURCE_MAP_SUPPORT) { + if (!process.env.ELECTRON_WEBPACK_DISABLE_SOURCE_MAP_SUPPORT) { html = html.replace("", ''); }