From 745e7689981ebf9fcc7fce5c4f411a3110fa7ae1 Mon Sep 17 00:00:00 2001 From: Mark Lee Date: Tue, 16 Jul 2019 08:18:01 -0700 Subject: [PATCH] refactor(core): use Object.entries when mapping makeTargets in the v5 importer --- packages/api/core/src/util/upgrade-forge-config.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/api/core/src/util/upgrade-forge-config.ts b/packages/api/core/src/util/upgrade-forge-config.ts index 864e1d6229..79129d8b79 100644 --- a/packages/api/core/src/util/upgrade-forge-config.ts +++ b/packages/api/core/src/util/upgrade-forge-config.ts @@ -7,12 +7,13 @@ import { import path from 'path'; import { siblingDep } from '../api/init-scripts/init-npm'; +type MakeTargets = { string: string[] }; + function mapMakeTargets(forge5Config: any): Map { const makeTargets = new Map(); if (forge5Config.makeTargets) { - // TODO: Use object.entries when dropping Node 6 - for (const platform of Object.keys(forge5Config.makeTargets)) { - for (const target of forge5Config.makeTargets[platform]) { + for (const [platform, targets] of Object.entries(forge5Config.makeTargets as MakeTargets)) { + for (const target of targets) { let platforms = makeTargets.get(target); if (platforms === undefined) { platforms = [];