Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

src: replace SetAccessor w/ SetAccessorProperty #38

Merged
merged 2 commits into from
Jun 15, 2018

Commits on Jun 14, 2018

  1. src: replace SetAccessor w/ SetAccessorProperty

    PR-URL: nodejs/node#17665
    Fixes: nodejs/node#17636
    Refs: nodejs/node#16482
    Refs: nodejs/node#16860
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    jure authored and ckerr committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    a3e6208 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2018

  1. test: make test-tls-external-accessor agnostic

    Remove reliance on V8-specific error messages in
    test/parallel/test-tls-external-accessor.js.
    
    Check that the error is a `TypeError`.
    
    The test should now be successful without modification using ChakraCore.
    
    Backport-PR-URL: nodejs/node#20456
    PR-URL: nodejs/node#16272
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Trott authored and jasonrudolph committed Jun 15, 2018
    Configuration menu
    Copy the full SHA
    ca3e746 View commit details
    Browse the repository at this point in the history