Patch 1 #67
Open
Patch 1 #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the operand stack and local variables are properly handled when frames are manipulated. Here's an improvement to this part of the code, where we make sure that the correct frame type and operand stack size are calculated
Redundant Retransformation Check: Before retransformation, the method alreadyInstrumented(clazz) checks if the class has already been instrumented by the agent to avoid redundant retransformation. Marking Classes as Instrumented: After retransformation, the method markAsInstrumented(clazz) adds a system property to track which classes have already been instrumented. This ensures that the same class isn't re-instrumented multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of the improvements:
Redundant Retransformation Check:
Before retransformation, the method alreadyInstrumented(clazz) checks if the class has already been instrumented by the agent to avoid redundant retransformation.
Marking Classes as Instrumented:
After retransformation, the method markAsInstrumented(clazz) adds a system property to track which classes have already been instrumented. This ensures that the same class isn't re-instrumented multiple times.
Transform.java:
Ensure that the operand stack and local variables are properly handled when frames are manipulated. Here's an improvement to this part of the code, where we make sure that the correct frame type and operand stack size are calculated: