-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verification request timeouts #3566
Comments
In fact even web doesn't time them out when sending them (I can accept a verification request on android 2 minutes after sending one on web, and web is still waiting and responses once I do). Do we want timeouts at all? I think yes: verifications are interactive like calls, they should only notify if they're timely. |
The most useful things to do first would be to:
1 is subtle because to be done properly it need to use the age parameter on the event to get a good estimate of the event age. iOS uses a longer timeout because it just looks at the originserver TS I think, but 2 mins should be sufficient if we use age correctly. I was reproducing verification banners getting stuck after cancelled requests, but after trying to implement a fix I couldn't then repro the failure without the fix. |
From the few verifications I did, only having the option for it being synchronous (UI wise) and with a timeout created problems in different situations:
I see no good reason for a timeout if the UI is done inline in the chat. |
Looks like verification requests just don't time out on android
The text was updated successfully, but these errors were encountered: