Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification request timeouts #3566

Open
dbkr opened this issue Jun 24, 2021 · 3 comments
Open

Verification request timeouts #3566

dbkr opened this issue Jun 24, 2021 · 3 comments

Comments

@dbkr
Copy link
Member

dbkr commented Jun 24, 2021

Looks like verification requests just don't time out on android

@dbkr
Copy link
Member Author

dbkr commented Jun 25, 2021

In fact even web doesn't time them out when sending them (I can accept a verification request on android 2 minutes after sending one on web, and web is still waiting and responses once I do).

Do we want timeouts at all? I think yes: verifications are interactive like calls, they should only notify if they're timely.

@dbkr
Copy link
Member Author

dbkr commented Sep 10, 2021

The most useful things to do first would be to:

  1. Ignore any verification requests that arrive after a timeout (2 minutes, probably), and
  2. Make sure verification requests aren't displayed if a cancellation arrives immediately afterwards.

1 is subtle because to be done properly it need to use the age parameter on the event to get a good estimate of the event age. iOS uses a longer timeout because it just looks at the originserver TS I think, but 2 mins should be sufficient if we use age correctly.

I was reproducing verification banners getting stuck after cancelled requests, but after trying to implement a fix I couldn't then repro the failure without the fix.

@JanZerebecki
Copy link

JanZerebecki commented Nov 23, 2021

From the few verifications I did, only having the option for it being synchronous (UI wise) and with a timeout created problems in different situations:

I see no good reason for a timeout if the UI is done inline in the chat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants