Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix embedded mode #1201

Closed
SimonBrandner opened this issue Jul 7, 2023 · 0 comments · Fixed by #1225
Closed

Fix embedded mode #1201

SimonBrandner opened this issue Jul 7, 2023 · 0 comments · Fixed by #1225

Comments

@SimonBrandner
Copy link
Contributor

  • Don't revert anything
  • Use the livekit url from our config as a default, so if the state event doesn't have one, we'll use the one from our config.
  • EW will continue creating calls with no livekit url
  • Ideally we can still get embedded mode working today so that we don't ship it broken on call.element.io
@robintown robintown mentioned this issue Jul 7, 2023
Closed
dbkr added a commit that referenced this issue Jul 10, 2023
@dbkr
Add the livekit URL in matroyshka mode
ca0e843 
This is a bit of a hack, as commented. The way to make it less of a
hack is there too.

Fixes embedded mode, although users will get a permission prompt
without matrix-org/matrix-react-sdk#11209.

Fixes #1201
@dbkr dbkr mentioned this issue Jul 10, 2023
Merged
@github-project-automation github-project-automation bot moved this from Incoming to Closed in Element Call issue triage Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Element Call issue triage
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the livekit URL in matroyshka mode element-hq/element-call
1 participant
@SimonBrandner