Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is Modal.js plain JS rather than a base component? Why is the CSS in common.css? #135

Closed
ara4n opened this issue Aug 30, 2015 · 2 comments
Closed

Why is Modal.js plain JS rather than a base component? Why is the CSS in common.css? #135

ara4n opened this issue Aug 30, 2015 · 2 comments
Labels
P3 T-Task Tasks for the team like planning

Comments

@ara4n
Copy link
Member

ara4n commented Aug 30, 2015

No description provided.

@ara4n ara4n added the T-Task Tasks for the team like planning label Aug 30, 2015
@dbkr
Copy link
Member

dbkr commented Sep 7, 2015

I'm assuming because it doesn't fit into the tree like a normal component, but instead is a tool to display a component modally. Erik?

@ara4n ara4n added P3 T-Task Tasks for the team like planning and removed T-Task Tasks for the team like planning labels Sep 7, 2015
@ara4n
Copy link
Member Author

ara4n commented Oct 11, 2015

Apparently this is the 'portal' design pattern. Given it ain't broke for now, let's not fix it.

@ara4n ara4n closed this as completed Oct 11, 2015
@ara4n ara4n modified the milestone: Ragnarok Nov 29, 2015
t3chguy pushed a commit that referenced this issue Oct 17, 2024
@dbkr
Fix bell icons on room list hover being black squares (#135)
5f113c4 
* Fix bell icons on room list hover being black squares

The EchoStore wasn't being set up and therefore missed the client being
injected.

Patch from @t3chguy.

* Fix tests

...by mocking out createClient so it doesn't try to start a real client.

* More mocks

* Don't need this anymore either
t3chguy pushed a commit that referenced this issue Oct 17, 2024
@dbkr
Revert #124 and #135 (#139)
3a59556 
This seems to be causing a lot of weirdness, presumably because there's
another missing thing like in #135, but I don't know what it might be and
it feels like it might take a while to find. Backing these changes out
to fix develop while we sort it out.

Fixes #28179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbkr @ara4n