Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No autofocus when clicking "Reply in thread" if thread panel is already open #19821

Closed
weeman1337 opened this issue Nov 20, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#7181
Closed

No autofocus when clicking "Reply in thread" if thread panel is already open #19821

weeman1337 opened this issue Nov 20, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#7181
Assignees
@germain-gg
Labels
A11y A-Threads S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Milestone
App team 1.9.6

Comments

@weeman1337
Copy link
Contributor

Steps to reproduce

  1. Use the latest dev version from here https://develop.element.io/
  2. Enable Threads in Labs settings
  3. Choose any message and click "Reply in thread"
  4. Threads sidebar opens and the input field is focused
  5. Click "Reply in thread" for any other message

Outcome

What did you expect?

  • Everytime I cllick "Reply in thread" the input field should be focused so that I can start typing

What happened instead?

  • If the threads panel is already open, the input field doesn't receive the focus

Operating system

Ubuntu 20.04.3 LTS

Browser information

Firefox 94.0 (64-bit)

URL for webapp

https://develop.element.io/

Application version

Element version: b2e8f21-react-7f6f98443865-js-b2d83c1f80b5 Olm version: 3.2.3

Homeserver

matrix.org

Will you send logs?

No
@SimonBrandner
Copy link
Contributor

Possibly regressed by matrix-org/matrix-react-sdk#7167

@SimonBrandner SimonBrandner added A-Threads A11y S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Nov 20, 2021
@HarHarLinks HarHarLinks mentioned this issue Nov 20, 2021
Closed
@germain-gg germain-gg self-assigned this Nov 22, 2021
@germain-gg germain-gg added this to the App team 1.9.6 milestone Nov 22, 2021
@germain-gg germain-gg mentioned this issue Nov 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A11y A-Threads S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
App team 1.9.6
Development

Successfully merging a pull request may close this issue.

Fix composer focus after pasting matrix-org/matrix-react-sdk
3 participants
@germain-gg @weeman1337 @SimonBrandner