Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Info button in the top-right can get de-synced #20509

Closed
anoadragon453 opened this issue Jan 12, 2022 · 3 comments
Closed

Info button in the top-right can get de-synced #20509

anoadragon453 opened this issue Jan 12, 2022 · 3 comments
Assignees
@toger5
Labels
A-Right-Panel A-Room-View O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Cannot-Reproduce X-Regression

Comments

@anoadragon453
Copy link
Member

Steps to reproduce

image

Note that the info button is highlighted, but the right sidebar is not visible.

This is reproducible by:

  1. Closing the right sidebar in a room.
  2. Navigating to another room.
  3. Opening the right sidebar if it isn't already.
  4. Returning to the previous room.
  5. Notice that the info icon remains highlighted, even though the right sidebar is not currently shown.

Outcome

What did you expect?

The status of the highlight to be consistent with whether the sidebar is shown.

What happened instead?

Chaos! As shown by the screenshot above.

Operating system

Arch Linux

Application version

Element Nightly version: 2022011101, Olm version: 3.2.8

How did you install the app?

https://aur.archlinux.org/packages/element-desktop-nightly-bin/

Homeserver

No response

Will you send logs?

No
@anoadragon453
Copy link
Member Author

It actually looks like it's not always reproducible with the above step, and that it can affect other top-right buttons as well:

image

@SimonBrandner SimonBrandner added A-Right-Panel A-Room-View O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jan 13, 2022
@toger5 toger5 self-assigned this Jan 13, 2022
@toger5
Copy link
Contributor

toger5 commented Jan 13, 2022

I tried with multiple rooms and panels but I cannot reproduce the issue.
But I have ran into this during development. I cannot recall what exactly was done when. Can you try with your account on develop.element.io?

@toger5
Copy link
Contributor

toger5 commented Jan 13, 2022

This got fixed recently by @jryans (THANKS ! )
matrix-org/matrix-react-sdk#7506

@toger5 toger5 closed this as completed Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toger5 toger5

Labels
A-Right-Panel A-Room-View O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Cannot-Reproduce X-Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@germain-gg @anoadragon453 @t3chguy @toger5 @SimonBrandner